Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using wasm drop method results in warnings flood #6505

Closed
PabloBuchu opened this issue May 2, 2023 · 10 comments · Fixed by #7038
Closed

Using wasm drop method results in warnings flood #6505

PabloBuchu opened this issue May 2, 2023 · 10 comments · Fixed by #7038
Assignees
@farmaazon
Labels
--bug Type: bug p-high Should be completed in the next sprint

Comments

@PabloBuchu
Copy link
Contributor

This is an issue to fix leftovers after implementing wasm.drop method. Original problem was rised during QAing #6365 (comment)

Steps to reproduce:

  1. Open Enso with -debug.dev-tools flag
  2. Navigate to console pane
  3. Type ensoglApp.wasm.drop()
  4. Warnings will flood both console and terminal

https://drive.google.com/file/d/1Oy3-D5JGYy4PbJhYAXYXB3Ouuks_zL45/view?usp=share_link
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board May 2, 2023
@PabloBuchu PabloBuchu added --bug Type: bug p-medium Should be completed in the next few sprints labels May 2, 2023
@sylwiabr sylwiabr added this to the Design Partners milestone May 2, 2023
@sylwiabr sylwiabr moved this from ❓New to 📤 Backlog in Issues Board May 2, 2023
@wdanilo
Copy link
Member

wdanilo commented May 3, 2023

This is more serious than it looks. If we are still trying to render after the drop, when Pawel will create a new project after the drop and re-initialize the app, we can have WebGL errors in the new instance because of that.

@PabloBuchu PabloBuchu added p-high Should be completed in the next sprint and removed p-medium Should be completed in the next few sprints labels May 5, 2023
@farmaazon farmaazon assigned Procrat and unassigned farmaazon May 25, 2023
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 25, 2023
@PabloBuchu PabloBuchu mentioned this issue May 29, 2023
Closed
@Procrat Procrat mentioned this issue May 31, 2023
Merged
4 tasks
@farmaazon farmaazon assigned farmaazon and unassigned farmaazon Jun 1, 2023
@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jun 9, 2023
@farmaazon farmaazon moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Jun 12, 2023
@enso-bot
Copy link

enso-bot bot commented Jun 14, 2023

Adam Obuchowicz reports a new STANDUP for yesterday (2023-06-13):

Progress: A little progress yesterday, as I spent most time on reviewing Wojciech's PR. Tried to find which Callback is left in JS. Found that only keydown events are printing the error log. It should be finished by 2023-06-14.

Next Day: Next day I will be working on the #6850 task. If time allows (I still need to finish review), I will start implementing the designed solution for "not-connectable" ports problem.

@farmaazon farmaazon moved this from 🌟 Q/A review to 🔴 Changes requested in Issues Board Jun 14, 2023
@farmaazon farmaazon mentioned this issue Jun 15, 2023
Merged
4 tasks
@farmaazon farmaazon moved this from 🔴 Changes requested to 👁️ Code review in Issues Board Jun 16, 2023
@farmaazon farmaazon moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Jun 20, 2023
@mergify mergify bot closed this as completed in #7038 Jun 20, 2023
mergify bot pushed a commit that referenced this issue Jun 20, 2023
@farmaazon
Fix leaks after calling wasm drop (#7038)
31956aa 
1. Fixed leaks of Scene. We were making several cycles of Rc references.
2. Fix removing event listeners: the remove listener option should take same options as those passed in addEventListener.

This should finally fix #6505
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Jun 20, 2023
@xvcgreg
Copy link

xvcgreg commented Jun 26, 2023

@farmaazon, unfortunately, @PabloBuchu can still observe the regression here

@xvcgreg xvcgreg reopened this Jun 26, 2023
@github-project-automation github-project-automation bot moved this from 🟢 Accepted to ❓New in Issues Board Jun 26, 2023
@farmaazon
Copy link
Contributor

@xvcgreg what do you mean? Do you have any additional info?

@xvcgreg
Copy link

xvcgreg commented Jun 26, 2023

@farmaazon just a direct message from @PabloBuchu that he can observe the problem still - please contact him directly as he has observed the issue.

@wdanilo
Copy link
Member

wdanilo commented Jun 26, 2023

@PabloBuchu should post here the details probably.

@PabloBuchu
Copy link
Contributor Author

@farmaazon sorry was to fast to reopen.. I can't know reproduce it.. Normal drop works fine as intendent, but couple of times I got framebuffer warnings again.

Closing for now

cc @wdanilo @xvcgreg

@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Jun 26, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jun 28, 2023
@PabloBuchu
Copy link
Contributor Author

@farmaazon is this related to this bug or is it because my project failed for some other problems? When I closed the project I got a lot
[90352:0704/095711.010502:ERROR:CONSOLE(6)] "console.assert", source: devtools://devtools/bundled/panels/console/console.js (6)

and

GL_INVALID_FRAMEBUFFER_OPERATION: Framebuffer is incomplete: Attachment has zero size. errors.

Screen.Recording.2023-07-04.at.09.56.24.mov

@farmaazon
Copy link
Contributor

farmaazon commented Jul 4, 2023 •
edited
Loading

I don't know where "console.assert" messages come from, but the warnings suggest there is still some rendering done, so probably it's somehow relevant.

@farmaazon farmaazon reopened this Jul 4, 2023
@github-project-automation github-project-automation bot moved this from 🗄️ Archived to ❓New in Issues Board Jul 4, 2023
@farmaazon farmaazon mentioned this issue Aug 1, 2023
Closed
@jdunkerley jdunkerley removed this from the Design Partners milestone Aug 30, 2023
@jdunkerley
Copy link
Member

Closing as wont be fixed given VueJS move.

@jdunkerley jdunkerley closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

Labels
--bug Type: bug p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix leaks after calling wasm drop enso-org/enso
7 participants
@Procrat @wdanilo @PabloBuchu @farmaazon @jdunkerley @sylwiabr @xvcgreg