This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Tweak tags for blog posts #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blog post tagging had gotten kind of gnarly of late. For one, there was a "Recent Posts" tag that was applied in a varied number of ways, and additionally it was unclear how releases and ember-data releases should be tagged. Consequently there was a variety of junk on the left side of the page. To improve the meaning of the categories we have, I've edited tags with these goals: * An Ember.js release post should be tagged "Releases". It should not be tagged "Recent Posts". It may be tagged "Security". * An Ember-Data release post should be tagged "Ember-Data". It should not be tagged "Recent Posts" or "Releases". It may also be tagged "Security" * A non-release post, or a non-Ember non-Ember-Data release post, should be tagged "Recent Posts". Other tags are welcome. There remain a series of old core team notes on the blog that I have not re-tagged to "Recent Posts". They seem ok on their own, even though there is no UI. I've tweaked the count of displayed recent posts to be much shorter, as the are not super common.
|
lgtm 🏣 |
|
LGTM |
I believe if we hit merge this should immediately show up on the site as well ...
|
@acorncom that PR adds responsiveness and pagination, but I don't believe it addresses some of the things that editing the tags improves. For example in the screenshots he uses "Ember Data 0.13" is still a prominent link, obviously not so important we want it shown to visitors on the landing page. I'm going to land this as-is, but let me know if there is more feedback! |
|
Hm does not seem to have auto-deployed. Going to publish a build by hand. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blog post tagging had gotten kind of gnarly of late. For one, there was a "Recent Posts" tag that was applied in a varied number of ways, and additionally it was unclear how releases and ember-data releases should be tagged. Consequently there was a variety of junk on the left side of the page.
To improve the meaning of the categories we have, I've edited tags with these goals:
There remain a series of old core team notes on the blog that I have not re-tagged to "Recent Posts". They seem ok on their own, even though there is no UI.
I've tweaked the count of displayed recent posts to be much shorter, as they are not super common.
Looks like:
/cc @bmac @tomdale @locks @acorncom @trek @wifelette