Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

responsive blog with pagination #2595

Merged
merged 1 commit into from
May 27, 2016
Merged

Conversation

nithindavid
Copy link
Contributor

Added pagination to blog pages and made it responsive ! please close this #2594 duplicate Pull request

@locks
Copy link
Contributor

locks commented May 21, 2016

Can you post some screenshots/gifs so we can do a visual check, please?

@nithindavid
Copy link
Contributor Author

Here are some screenshots

image
image
image
image

@acorncom
Copy link
Contributor

Looks good, thank you!

@acorncom acorncom merged commit 8b95245 into emberjs:master May 27, 2016
@nithindavid
Copy link
Contributor Author

Blog authors will to have add "responsive: true" property to blog post pages to make them responsive

@mixonic
Copy link
Member

mixonic commented May 30, 2016

@webofnithin could you possibly make a followup PR where the default is responsive and old problematic articles are flagged responsive: false? I worry we will not remember to put responsive: true in the header of every blog post. There are several authors and keeping them up to date on this kind of boilerplate is hard. I'd prefer a responsive default is possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants