Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Ember 2.10 unified blog post #2727

Merged
merged 1 commit into from
Nov 30, 2016
Merged

Ember 2.10 unified blog post #2727

merged 1 commit into from
Nov 30, 2016

Conversation

locks
Copy link
Contributor

@locks locks commented Nov 28, 2016

Rendered. Ship approvals (once nominated as complete and we remove the WIP):


Draft

Ember

  • 2.10 changes
  • 2.11 beta upcoming changes

Ember Data

  • 2.10 changes
  • 2.11 beta changes

Ember CLI

  • Ember / Ember Data upgrade instructions
  • 2.10 changes
  • 2.11 changes

One of the performance improvements included in the Ember Data
2.11.0-beta.1 release fixed an issue where Ember Data was doing too
much work when records in a `DS.hasMany()` changed. As a result of
this extra work Ember Data would incorrectly invalid computed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalidate


[@runspired](https://github.com/runspired) also
[improved the messaging](https://github.com/emberjs/data/pull/4578)
around assertions and warnings when an adapter responses with no `id`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responds*

`record.serialize()` in place of `store.serialize(record)` or
`snapshot.serialize()` in place of
`adapter.serialize(snapshot)`. `store#serialize()` and
`adapter#serialize()` will be removed in Ember Data 3.0.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's at least one other deprecation to public API in 2.11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/emberjs/data/blob/master/addon/-private/system/store.js#L2595-L2609

^ newly deprecated methods lookupAdapter and lookupSerializer, these were never fully public or private and should get a mention.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

store.recordIsLoaded deprecation emberjs/data#4665

@nathanhammond
Copy link
Member

I've completed the CLI draft. You're encouraged to directly make edits and commit to this branch to improve it as you see fit. If I disagree we'll fix forward.

@runspired
Copy link

We should mention the other deprecations or link to the release notes with them for 2.11 beta, but otherwise the ED section is looking good to me.

@chancancode
Copy link
Member

Today, the Ember project is releasing Ember.js, Ember Data and Ember CLI
version 2.10.0.

This also kicks off the 2.11 beta cycle for all sub-projects. We enourage our
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*encourage


### Changes in Ember Data 2.10

Ember Data 2.10 represents the work of over 11 direct contributors and over
27 commits.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of "over" in this sentence is a bit confusing combined with such specific numbers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -123,7 +158,7 @@ which should be non-breaking. If you experience issues you will
Concatenation of assets has been implicit based upon file-system ordering. An
update to `broccoli-concat` which changed the walk order of the file system to
guarantee consistency and stable concatenation broke the implicit reliance we
had on that ordering. To ensure that we were backwards compatible
had on that ordering. To ensure that we were backwards compatible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider replacing "were backwards compatible" with "remain backwards compatible"


This also kicks off the 2.11 beta cycle for all sub-projects. We enourage our
community (especially addon authors) to help test these beta builds and report
any bugs before they are published as a final release in six weeks' time. (The
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no parens around last sentence

- [The Ember Project](http://emberjs.com/blog/2015/06/16/ember-project-at-2-0.html)
- [Ember LTS Releases](http://emberjs.com/blog/2016/02/25/announcing-embers-first-lts.html)

---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small note about unified blog post? "We're trying out this format, let us know what you think"? maybe too informal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think all visitors need to be asked to let us know about the format. Seems a good thing to ask for feedback on in Slack after the fact.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note about it in the release process section

Ember CLI is the command line interface for managing and packaging Ember.js
applications.

### Upgrading Ember CLI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other sub-projects should have a matching section maybe?

For more details on the changes in Ember.js 2.10, please review the
[Ember.js 2.10.0 release page](https://github.com/emberjs/ember.js/releases/tag/v2.10.0).

### Upcoming changes in Ember.js 2.11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried this might frame as "they're definitely coming", but in the Data section there's already an exception to the rule. am I reading too much into it?

@@ -174,6 +212,14 @@ making rebuilds work for changes in that directory.
- Stefan Penner [made it so we do a better job at cleanup up on exit of Ember CLI](https://github.com/ember-cli/ember-cli/pull/6423)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/up on/upon/

There are many other improvements, and as always we're grateful to our contributors for their efforts.
As a community-driven open-source project with an ambitious scope, each of
these releases serve as a reminder that the Ember project would not have been
possible without your continued support. We are extremely greatful to our
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/greatful/grateful/

fix you may need to update computed property keys that depended on
`record.hasManyRelationshipName` to `record.hasManyRelationshipName.[]`.

#### Deprecate store.serialize

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments from before seemed to get lost so I'll redo them quick. 2.11 also deprecates:


`store#lookupAdapter()` and `store#lookupSerializer()` have also been
deprecated starting in Ember 2.11. These methods were never publicly
documented. In their place we recommended you use `store#adapterFor()`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:s/recommended/recommend

@locks
Copy link
Contributor Author

locks commented Nov 29, 2016

Should we also include the Ember, Ember Data, Ember CLI tags to the metadata?

@mixonic
Copy link
Member

mixonic commented Nov 29, 2016

The tags pick what sidebar menu the post appears in. And the blog isn't currently set up for bundled Ember Data and Ember releases. Current sidebars are:

  • Recent posts
  • Releases
  • Ember Data

Per the last cleanup PR. A blog post should only be in one of those categories, IMO. So I'd suggest this be in the Releases tag only.

I think a good followup PR would be to migrate existing "Ember Data" tagged blog posts to have the "Releases" tag, drop the ember-data sidebar, then expand the releases to take 14 instead of 7. But it seems good to split that work out.

@chancancode
Copy link
Member

I just finished writing my part. Am I supposed to get someone else to approve it? I nominate @mixonic 😬

20 commits.

There have been no user facing changes in Ember Data 2.10. Under the
hood, [@runspired](https://github.com/runspired) has instrumented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we normalize these mentions to use real names (see the Ember section above)? @runspired do you mind?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we've used handles in blog posts, but I am aok with swapping to names. I kind of like it in fact.

There can be issues with names I suppose, but with handles there are times when twitter/github disagree and knowing which to pick is difficult.

#### HasMany Computed Property Keys

One of the performance improvements included in the Ember Data
2.11.0-beta.1 release fixes an issue where Ember Data was doing too
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "2.11" per fa1d1d5

Thanks to everyone in the community who took the time to test their apps and
addons against the Glimmer 2 alpha and beta builds, this has been one of the
most rigorously tested release in the history of the Ember project. We are
quite confident that upgrade with go smoothly for most apps. However, if you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be will go smoothly instead of with go?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

[March 2015](https://github.com/emberjs/data/pull/2875).

All of the deprecated methods mentioned above will remain in Ember
Data until v3.0.0. Until then they will log a deprecation warning to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"3.0"... I think..

adapter operation should look like: specify the used HTTP method or
provide custom HTTP headers per request. This feature has been enabled
in the beta channel in 2.8-beta and has been enabled in the beta
channel since.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I understand the subtlety this is trying to get across (after reading it a few times), but it is a bit clumsy. Does "This feature has been in beta since Ember Data 2.8" preserve enough of that technicality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!


#### Testing Addons

Ember CLI v2.10 removes Ember.js v1.13 from the default testing matrix in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ember CLI 2.10" and "Ember.js 1.13"


Ember CLI v2.10 removes Ember.js v1.13 from the default testing matrix in the
addon blueprint. Given that we now have two LTS releases in the v2.X series of
Ember.js we no longer feel that supporting Ember.js v1.13 is a reasonable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Ember CLI v2.10 removes Ember.js v1.13 from the default testing matrix in the
addon blueprint. Given that we now have two LTS releases in the v2.X series of
Ember.js we no longer feel that supporting Ember.js v1.13 is a reasonable
default for newly-created addons. You may continue to support Ember.js v1.13 in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

In our continous incremental progress toward making `bower` optional inside of
Ember CLI we have moved to include Ember.js itself via
[`ember-source`](https://www.npmjs.com/package/ember-source)–provided via `npm`.
In v2.11.0 we will no longer have any packages provided by `bower` in a brand
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.11

new Ember application! Please help us test this by attempting to upgrade your
applications and reporting any issues you discover, both in your applications
and in CI using `ember-try`. We want to make sure that the upgrade process to
Ember CLI and Ember.js v2.11.0 is as smooth as possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

and in CI using `ember-try`. We want to make sure that the upgrade process to
Ember CLI and Ember.js v2.11.0 is as smooth as possible.

Ember CLI v2.11.0 will not officially support Node.js v0.12 per the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@mixonic
Copy link
Member

mixonic commented Nov 29, 2016

I've taken the initiative to check off the boxes in the issue description for @nathanhammond and @locks 😬 I'm personally good to go here. ‼️ ‼️ ‼️ GLIMMER2 ‼️ ‼️ ‼️

@chancancode
Copy link
Member

Looks like Ember CLI hasn't cut the releases yet, unchecked their box for now


Thanks to everyone in the community who took the time to test their apps and
addons against the Glimmer 2 alpha and beta builds, this has been one of the
most rigorously tested release in the history of the Ember project. We are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...most rigorously tested release releases in the history...

addons against the Glimmer 2 alpha and beta builds, this has been one of the
most rigorously tested release in the history of the Ember project. We are
quite confident that upgrade will go smoothly for most apps. However, if you
encountered any issues, please do report them to the [issue tracker](https://github.com/emberjs/ember.js/issues/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, if you encountered encounter any issues

for us, creating a much better foundation for adding new features as well as
room for future performance impovements. With the initial integration now out
of the way, we are quite excited to return our efforts to those areas in the
upcoming releases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...those areas in the upcoming releases.

[WeakMap](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap)
to [store object metadata](https://github.com/emberjs/ember.js/pull/13783) on
browsers that supports them. A plesant side-effects of this internal change is
that Ember no longer add an `__ember_meta__` property to every object.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add => adds

Second, thanks to [Robert Jackson](https://github.com/rwjblue), we now use
[WeakMap](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap)
to [store object metadata](https://github.com/emberjs/ember.js/pull/13783) on
browsers that supports them. A pleasant side-effects of this internal change is
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"side-effects" should be singular.

@mixonic
Copy link
Member

mixonic commented Nov 29, 2016

Perhaps we should mention in the Ember section that one may want to upgrade addons that may have relied in internal APIs when upgrading Ember. And/or list known addons that should be bumped.

@mixonic mixonic changed the title [WIP] Ember 2.10 unified blog post Ember 2.10 unified blog post Nov 29, 2016

#### Move `ds-improved-ajax` out of `beta` channel

The `ds-improved-feature` implemented in

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ds-improved-ajax?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check and update :-) Thanks.

@mixonic mixonic merged commit 29b9ba6 into master Nov 30, 2016
@mixonic mixonic deleted the ember-2-10-release branch November 30, 2016 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.