Field list - from indexed array to arrays and maps #47921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
force-pushed
the
field_list_not_indexed-array_v2
branch
from
142511e to
08ad9ad
Compare
💔 Build Failed
|
💔 Build Failed
|
mattkime
force-pushed
the
field_list_not_indexed-array_v2
branch
from
1b2f34c to
febac6e
Compare
💔 Build Failed |
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
mattkime
added
v8.0.0
v7.5.0
release_note:plugin_api_changes
|
retest |
💚 Build Succeeded |
mattkime
changed the title
ppisljar
approved these changes
Oct 14, 2019
| remove(field: FieldType): void; | ||
| } | ||
|
|
||
| export class FieldList extends Array<Field> implements FieldListInterface { |
There was a problem hiding this comment.
nit: can we loose extends Array as thats already part of FieldListInterface definition ?
There was a problem hiding this comment.
It appears to be needed. Seems that FieldList doesn't inherit that trait from FieldListInterface.
| (function flatten(obj, keyPrefix = '') { | ||
| keyPrefix = keyPrefix ? keyPrefix + '.' : ''; | ||
| _.forOwn(obj, function(val, key) { | ||
| key = keyPrefix + key; | ||
|
|
||
| if (deep) { | ||
| const isNestedField = fields[key] && fields[key].type === 'nested'; | ||
| const field = fields(key); |
|
@elasticmachine merge master |
|
@elasticmachine update branch |
💚 Build Succeeded |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Oct 14, 2019
* make fieldList extend array
mattkime
added
release_note:skip
6 tasks
mattkime
added a commit
that referenced
this pull request
Oct 14, 2019
💚 Build Succeeded |
|
I think this PR is the culprit for the following console error I'm seeing now when hovering over the magnifying glasses in Discover for filtering on fields:
Reason being is that the field list now contains a direct reference to the index pattern it is created from, which also has the field list. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed field list from indexed array to a native array and maps.
The field list interface is here - https://github.com/elastic/kibana/pull/47921/files#diff-7fdc99852731187e4db7a38a227962abR25
The rest of the pr concerns changes related to consuming the altered api.
[x] Test with beats - thousands of fields
addresses #43440