[Maps] fix propType warnings for source with joins #48905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
Prop type errors caused by Field list - from indexed array to arrays and maps. That PR switched IndexPattern.Fields from an Indexed array object to just a standard Javascript array. Need to update prop types to accept array instead of object. |
💚 Build Succeeded |
thomasneirynck
approved these changes
Oct 22, 2019
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 22, 2019
* [Maps] fix propType warnings for source with joins * only accept arrays
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 22, 2019
* [Maps] fix propType warnings for source with joins * only accept arrays
nreese
added a commit
that referenced
this pull request
Oct 22, 2019
nreese
added a commit
that referenced
this pull request
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #48837