Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes field formatter used for chart and anomaly table values #49030

Merged
merged 2 commits into from
Oct 23, 2019
Merged

[ML] Fixes field formatter used for chart and anomaly table values #49030

merged 2 commits into from
Oct 23, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Oct 23, 2019 •
edited
Loading

Summary

Fixes a regression introduced by the changes to the index pattern field list in #47921, which meant the formatter configured for a field in the index pattern was no longer be applied when displaying values in anomaly charts and tables.

Before:

field_format_before

After:

image

Checklist

Fixes #48873

@peteharverson peteharverson added review :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 labels Oct 23, 2019
@peteharverson peteharverson requested a review from a team as a code owner October 23, 2019 12:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko
Copy link
Member

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jgowdyelastic
jgowdyelastic approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit 7f55c95 into elastic:master Oct 23, 2019
@peteharverson peteharverson deleted the ml-field-format-fix branch October 23, 2019 17:03
@peteharverson peteharverson mentioned this pull request Oct 23, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Oct 23, 2019
@peteharverson
[ML] Fixes field formatter used for chart and anomaly table values (e…
4ce4254 
…lastic#49030)
@peteharverson peteharverson mentioned this pull request Oct 23, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Oct 23, 2019
@peteharverson
[ML] Fixes field formatter used for chart and anomaly table values (e…
da3f7aa 
…lastic#49030)
peteharverson added a commit that referenced this pull request Oct 23, 2019
@peteharverson
[ML] Fixes field formatter used for chart and anomaly table values (#…
5dfad99 
…49030) (#49084)
peteharverson added a commit that referenced this pull request Oct 23, 2019
@peteharverson
[ML] Fixes field formatter used for chart and anomaly table values (#…
57025c5 
…49030) (#49085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Single metric viewer - tooltip values don't have thousands separators and decimal places
5 participants
@peteharverson @elasticmachine @dmlemeshko @walterra @jgowdyelastic