Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Show error toast on failure #179335

Merged
merged 5 commits into from
Mar 25, 2024
+19 −1
Merged

[Obs AI Assistant] Show error toast on failure #179335

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf4da37
[Obs AI Assistant] Show error toast on failure
miltonhultgren Mar 25, 2024
60dea26
Use .catch instead of useEffect
miltonhultgren Mar 25, 2024
25f02a7
Re-throw erro
miltonhultgren Mar 25, 2024
42c8a9c
Add translation of error title
miltonhultgren Mar 25, 2024
d6ade35
Merge branch 'main' into oaia-show-error-on-failure
miltonhultgren Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...rvability_solution/observability_ai_assistant_app/public/components/nav_control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export function NavControl({}: {}) {

const {
services: {
notifications,
plugins: {
start: {
observabilityAIAssistant: { ObservabilityAIAssistantChatServiceContext },
Expand All @@ -41,6 +42,19 @@ export function NavControl({}: {}) {
[service, hasBeenOpened]
);

useEffect(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is L39 not a better place to handle it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because useAbortableAsync doesn't bubble the error up from the Promise creation function, it sets it as part of the state of the hook and returns it (same as for .value).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add a catch handler before the value is returned though, e.g. service.start({ signal }).catch(notifyError)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 60dea26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have to look at the code to see what you're doing. In your latest change, you'll want to rethrow the error after creating the notification, otherwise it looks like it actually succeeded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25f02a7

if (!chatService.error) {
return;
}

notifications.toasts.addError(chatService.error, {
title: 'Failed to initialize Observability AI Assistant',
});

setHasBeenOpened(false);
setIsOpen(false);
}, [chatService.error, notifications.toasts]);

const [isOpen, setIsOpen] = useState(false);

const keyRef = useRef(v4());
Expand Down
Loading