[Obs AI Assistant] Show error toast on failure #179335
Conversation
miltonhultgren
added
release_note:skip
|
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
| @@ -41,6 +42,19 @@ export function NavControl({}: {}) { | |||
| [service, hasBeenOpened] | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
is L39 not a better place to handle it?
There was a problem hiding this comment.
No, because useAbortableAsync doesn't bubble the error up from the Promise creation function, it sets it as part of the state of the hook and returns it (same as for .value).
There was a problem hiding this comment.
you can add a catch handler before the value is returned though, e.g. service.start({ signal }).catch(notifyError)
There was a problem hiding this comment.
Fixed in 60dea26
There was a problem hiding this comment.
I would have to look at the code to see what you're doing. In your latest change, you'll want to rethrow the error after creating the notification, otherwise it looks like it actually succeeded
| return hasBeenOpened | ||
| ? service.start({ signal }).catch((error) => { | ||
| notifications.toasts.addError(error, { | ||
| title: 'Failed to initialize Observability AI Assistant', |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
miltonhultgren
removed
the
backport:prev-minor
kibanamachine
added
backport:skip
If the call to
ObservabilityAIAssistantAppService.startfails, show an error toast to notify the user.