Use .catch instead of useEffect

elastic · Mar 25, 2024 · 60dea26 · 60dea26
1 parent bf4da37
commit 60dea26
Showing 1 changed file with 10 additions and 14 deletions.
diff --git a/...rvability_solution/observability_ai_assistant_app/public/components/nav_control/index.tsx b/...rvability_solution/observability_ai_assistant_app/public/components/nav_control/index.tsx
@@ -37,24 +37,20 @@ export function NavControl({}: {}) {
 
   const chatService = useAbortableAsync(
     ({ signal }) => {
-      return hasBeenOpened ? service.start({ signal }) : undefined;
+      return hasBeenOpened
+        ? service.start({ signal }).catch((error) => {
+            notifications.toasts.addError(error, {
+              title: 'Failed to initialize Observability AI Assistant',
+            });
+
+            setHasBeenOpened(false);
+            setIsOpen(false);
+          })
+        : undefined;
     },
     [service, hasBeenOpened]
   );
 
-  useEffect(() => {
-    if (!chatService.error) {
-      return;
-    }
-
-    notifications.toasts.addError(chatService.error, {
-      title: 'Failed to initialize Observability AI Assistant',
-    });
-
-    setHasBeenOpened(false);
-    setIsOpen(false);
-  }, [chatService.error, notifications.toasts]);
-
   const [isOpen, setIsOpen] = useState(false);
 
   const keyRef = useRef(v4());