[Saved object] prevent deleting managed content from UI #176443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
jloleysens
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Overall looking good @drewdaemon ! Thanks for making this improvement. I left a few comments that I'd like to get your thoughts on before approving.
...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
Outdated
Show resolved
Hide resolved
...jects_management/public/management_section/objects_table/components/delete_confirm_modal.tsx
Outdated
Show resolved
Hide resolved
|
@jloleysens I have unified the behavior of hidden and managed saved objects. Could you take another look? |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Feb 9, 2024
Comment on lines
+105
to
+109
| <p | ||
| css={css` | ||
| margin-block-end: 0 !important; | ||
| `} | ||
| > |
There was a problem hiding this comment.
🙈 In theory we should be able to do this without inline css just with EUI components, don't we?
There was a problem hiding this comment.
If the concern is around inline CSS (?) this uses emotion so it generates a class for this element.
Comment on lines
+405
to
+407
| selectedSavedObjects.filter( | ||
| ({ managed, meta: { hiddenType } }) => !managed && !hiddenType | ||
| ).length === 0 || !capabilities.savedObjectsManagement.delete |
There was a problem hiding this comment.
NIT: I would memo this now that we're doing a full array lookup via filter
There was a problem hiding this comment.
Sorry, I missed these comments. This is a good idea. Will open a follow-up
jloleysens
approved these changes
Feb 9, 2024
kibanamachine
added
v8.13.0
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Closes elastic#172391 This change stops users from deleting managed content from the SO management page by - keeping the delete action disabled when the selection contains only managed content - excluding managed content from the list in the delete modal https://github.com/elastic/kibana/assets/315764/5bfa974e-823e-4c35-b6b9-71fcd08bf5e8 <img width="1673" alt="Screenshot 2024-02-07 at 12 53 29 PM" src="https://github.com/elastic/kibana/assets/315764/645238ec-dfe7-4f10-b468-df40e4fcb698"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — will be done in elastic#175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Closes elastic#172391 This change stops users from deleting managed content from the SO management page by - keeping the delete action disabled when the selection contains only managed content - excluding managed content from the list in the delete modal https://github.com/elastic/kibana/assets/315764/5bfa974e-823e-4c35-b6b9-71fcd08bf5e8 <img width="1673" alt="Screenshot 2024-02-07 at 12 53 29 PM" src="https://github.com/elastic/kibana/assets/315764/645238ec-dfe7-4f10-b468-df40e4fcb698"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — will be done in elastic#175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #172391
This change stops users from deleting managed content from the SO management page by
Screen.Recording.2024-02-07.at.12.53.56.PM.mov
Checklist
Delete any items that are not applicable to this PR.