Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Saved objects] Prevent deleting managed content from UI #172391

Closed
Tracked by #172393
drewdaemon opened this issue Dec 1, 2023 · 1 comment · Fixed by #176443
Closed
Tracked by #172393

[Saved objects] Prevent deleting managed content from UI #172391

drewdaemon opened this issue Dec 1, 2023 · 1 comment · Fixed by #176443
Assignees
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@drewdaemon
Copy link
Contributor

The users should be prevented from deleting managed content from the Saved Objects Management view.

UI changes

image12

Delete button is disabled when only managed content is selected

image11

Managed content is excluded from delete modal in the case of a mixed selection

@drewdaemon drewdaemon added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Dec 1, 2023
@drewdaemon drewdaemon self-assigned this Dec 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

drewdaemon added a commit that referenced this issue Feb 9, 2024
## Summary

Closes #172391

This change stops users from deleting managed content from the SO
management page by
- keeping the delete action disabled when the selection contains only
managed content
- excluding managed content from the list in the delete modal


https://github.com/elastic/kibana/assets/315764/5bfa974e-823e-4c35-b6b9-71fcd08bf5e8

<img width="1673" alt="Screenshot 2024-02-07 at 12 53 29 PM"
src="https://github.com/elastic/kibana/assets/315764/645238ec-dfe7-4f10-b468-df40e4fcb698">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — will be
done in #175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
## Summary

Closes elastic#172391

This change stops users from deleting managed content from the SO
management page by
- keeping the delete action disabled when the selection contains only
managed content
- excluding managed content from the list in the delete modal


https://github.com/elastic/kibana/assets/315764/5bfa974e-823e-4c35-b6b9-71fcd08bf5e8

<img width="1673" alt="Screenshot 2024-02-07 at 12 53 29 PM"
src="https://github.com/elastic/kibana/assets/315764/645238ec-dfe7-4f10-b468-df40e4fcb698">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — will be
done in elastic#175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
## Summary

Closes elastic#172391

This change stops users from deleting managed content from the SO
management page by
- keeping the delete action disabled when the selection contains only
managed content
- excluding managed content from the list in the delete modal


https://github.com/elastic/kibana/assets/315764/5bfa974e-823e-4c35-b6b9-71fcd08bf5e8

<img width="1673" alt="Screenshot 2024-02-07 at 12 53 29 PM"
src="https://github.com/elastic/kibana/assets/315764/645238ec-dfe7-4f10-b468-df40e4fcb698">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — will be
done in elastic#175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants