[Deployment management] Mark devtools and management sidenav deeplinks as visible on serverless #161226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #160349
Summary
Recently there has been some work to use deeplink ids for the sidenav instead of plain hrefs to avoid broken links #159125. This works goes over our
devtools
andmanagement
apps and conditionally sets the deeplinks as visible for the navbar if on serverless, otherwise we keep the default value (which ishidden
).This work follows a similar approach as taken by the observability team: #160620.
How to test
devtools
andmanagement
sections from the navbar arehidden: false
and that they havenavLinkStatus: 1
.To double check that the sections and links are not hidden and can be visible on navbar, edit the following file
packages/shared-ux/chrome/navigation/src/ui/components/navigation.tsx
and do the following:Then check in the browser devtools for the printed array of deeplinks, find
devtools
ormanagement
and make sure the sections aren't hidden.Screenshots