Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deployment management] Mark devtools and management sidenav deeplinks as visible on serverless #161226

Conversation

sabarasaba
Copy link
Member

Fixes: #160349

Summary

Recently there has been some work to use deeplink ids for the sidenav instead of plain hrefs to avoid broken links #159125. This works goes over our devtools and management apps and conditionally sets the deeplinks as visible for the navbar if on serverless, otherwise we keep the default value (which is hidden).

This work follows a similar approach as taken by the observability team: #160620.

How to test
  • Boot up any of the serverless solutions and make sure that both the devtools and management sections from the navbar are hidden: false and that they have navLinkStatus: 1.
  • Boot up classic kibana and make sure that the left navbar has the same menu entries it always had.

To double check that the sections and links are not hidden and can be visible on navbar, edit the following file packages/shared-ux/chrome/navigation/src/ui/components/navigation.tsx and do the following:

export function Navigation({ children, unstyled = false, dataTestSubj }: Props) {
  // const { onProjectNavigationChange, activeNodes$ } = useNavigationServices();
  const { onProjectNavigationChange, activeNodes$, navLinks$ } = useNavigationServices();
  const deepLinks = useObservable(navLinks$, []);
  console.log(deepLinks);

Then check in the browser devtools for the printed array of deeplinks, find devtools or management and make sure the sections aren't hidden.

Screenshots

Screenshot 2023-07-05 at 06 53 00
Screenshot 2023-07-05 at 06 52 52

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release v8.10.0 labels Jul 5, 2023
@sabarasaba sabarasaba self-assigned this Jul 5, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 5, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / core plugins rendering service exposes plugin config settings to authenticated users
  • [job] [logs] FTR Configs #33 / core plugins rendering service exposes plugin config settings to authenticated users

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
devTools 8 12 +4
management 47 49 +2
total +6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
devTools 10.9KB 11.2KB +262.0B
management 10.4KB 10.6KB +181.0B
total +443.0B
Unknown metric groups

API count

id before after diff
devTools 10 14 +4
management 47 49 +2
total +6

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@elastic elastic deleted a comment from kibanamachine Jul 5, 2023
@sabarasaba sabarasaba closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serverless] Stack Management and Dev Tools deeplinks are hidden, but needed for side nav
3 participants