Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless] Observability side navigation #160620

Merged
merged 6 commits into from
Jun 28, 2023
Merged

[Serverless] Observability side navigation #160620

merged 6 commits into from
Jun 28, 2023

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Jun 27, 2023 •
edited
Loading

fixes: #159681
fixes: #153777

image

Related

ML deep links won't show until it's merged #159433

Test

@kpatticha kpatticha requested review from a team as code owners June 27, 2023 13:04
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha requested a review from a team as a code owner June 27, 2023 16:34
@kpatticha kpatticha added Project:Serverless Work as part of the Serverless project for its initial release apm:serverless v8.10.0 labels Jun 27, 2023
@kpatticha kpatticha added the release_note:skip Skip the PR/issue when compiling release notes label Jun 27, 2023
@kc13greiner kc13greiner self-requested a review June 27, 2023 18:11
@kpatticha kpatticha mentioned this pull request Jun 27, 2023
Merged
kc13greiner
kc13greiner requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small codeowners change, otherwise LGTM!

@kpatticha kpatticha requested a review from kc13greiner June 28, 2023 07:59
yngrdyn
yngrdyn approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care 🪄

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
apm 47 48 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.6MB +20.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 35.9KB 36.2KB +308.0B
observabilityOnboarding 4.5KB 4.6KB +52.0B
serverlessObservability 18.0KB 17.8KB -110.0B
total +250.0B
Unknown metric groups

API count

id before after diff
apm 47 48 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kc13greiner
kc13greiner approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes - LGTM!

@kpatticha kpatticha merged commit 1a21965 into elastic:main Jun 28, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 28, 2023
@jgowdyelastic jgowdyelastic mentioned this pull request Jun 29, 2023
Merged
This was referenced Jul 5, 2023
Closed
Closed
Merged
kpatticha added a commit that referenced this pull request Jul 11, 2023
@kpatticha
Cypress for observability serverless (#160674)
8e80f19 
Created a separated PR in order setup a basic setup for cypress and test
#160620 for serverless.


 Basic setup to run cypress for serverless-oblt

#### How to  run it 

from
`x-pack/test_serverless/functional/test_suites/observability/cypress`
```
yarn cypress:serverless:open
```


![image](https://github.com/elastic/kibana/assets/3369346/8ba7dd80-a9a4-4777-898b-4d9f39bee118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

@kc13greiner kc13greiner kc13greiner approved these changes

Assignees
No one assigned
Labels
apm:serverless backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability] Set navLinkStatus for deeplinks [Observability] Serverless navigation
7 participants
@kpatticha @elasticmachine @apmmachine @kibana-ci @yngrdyn @kc13greiner @kibanamachine