Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Stack Management and Dev Tools deeplinks are hidden, but needed for side nav #160349

Closed
2 tasks
tsullivan opened this issue Jun 22, 2023 · 3 comments · Fixed by #161227
Closed
2 tasks
Assignees
Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

tsullivan commented Jun 22, 2023

This refers to: #159125 (comment)

The default "preset" deeplinks for Stack Management are marked as hidden. Therefore there are links to certain items under Stack Management.

This may be intentional, if the certain items should not be shown in serverless. However, any app that shouldn't be available in serverless should be prevented from registering with the Application Service entirely: "hidden" apps may still be available outside of the nav, such as through the Global Search bar.

cc @elastic/platform-deployment-management

Related: #159681


  • Dev tools
actual expected
N/A image

const deepLink = {
id: tool.id,
title: tool.title as string,
path: `#/${tool.id}`,
};


  • Management
actual expected
image image

deepLinks: section.getAppsEnabled().map((mgmtApp) => ({
id: mgmtApp.id,
title: mgmtApp.title,
path: mgmtApp.basePath,
keywords: mgmtApp.keywords,
})),

@tsullivan tsullivan added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Jun 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@tsullivan tsullivan added the Project:Serverless Work as part of the Serverless project for its initial release label Jun 22, 2023
@tsullivan tsullivan changed the title [Serverless/SideNav] Stack Management deeplinks needed for nav are hidden. [Serverless] Stack Management and Dev Tools deeplinks are hidden, but needed for side nav Jun 22, 2023
@tsullivan
Copy link
Member Author

tsullivan commented Jun 23, 2023

This issue might be moot since a new design for Stack Management is underway, and it might not involve any side nav links at all: #159545 cc @alisonelizabeth

Still, Solution teams may have a requirement to show specific links to Stack Management in a custom part of their side nav. They will use deeplinks to do so, and will need to have those deeplinks registered with the Application Service as "not hidden."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
3 participants