BulkAll() improvements #4014
Merged
BulkAll() improvements #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest keeps returning a bad statuscode
codebrain
pushed a commit
that referenced
this pull request
Aug 12, 2019
…equest keeps returning a bad statuscode (#4014) Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode.
|
Ported to |
codebrain
pushed a commit
that referenced
this pull request
Aug 12, 2019
…equest keeps returning a bad statuscode (#4014) Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode.
|
ported to 6.x |
russcam
pushed a commit
that referenced
this pull request
Aug 13, 2019
rmadisonhaynie
added a commit
to rmadisonhaynie/elasticsearch-net
that referenced
this pull request
Nov 6, 2020
Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode and ContinueOnDroppedDocuments is true. This was introduced in elastic#4014 when trying to address a similar issue with backOffTries being ignored.
stevejgordon
pushed a commit
that referenced
this pull request
Nov 12, 2020
Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode and ContinueOnDroppedDocuments is true. This was introduced in #4014 when trying to address a similar issue with backOffTries being ignored.
stevejgordon
pushed a commit
that referenced
this pull request
Nov 12, 2020
Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode and ContinueOnDroppedDocuments is true. This was introduced in #4014 when trying to address a similar issue with backOffTries being ignored.
stevejgordon
pushed a commit
that referenced
this pull request
Nov 12, 2020
Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode and ContinueOnDroppedDocuments is true. This was introduced in #4014 when trying to address a similar issue with backOffTries being ignored.
stevejgordon
added a commit
that referenced
this pull request
Nov 12, 2020
Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode and ContinueOnDroppedDocuments is true. This was introduced in #4014 when trying to address a similar issue with backOffTries being ignored. Co-authored-by: R. Madison Haynie <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Nov 12, 2020
Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode and ContinueOnDroppedDocuments is true. This was introduced in #4014 when trying to address a similar issue with backOffTries being ignored. (cherry picked from commit 9b65068) Co-authored-by: R. Madison Haynie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug and improves the run time behaviour of
BulkAll()If the
_bulkoperation itself keeps returning an invalid status code theBulkAll()could potentially hang, As reported on Check backOffRetries before retrying in HandleBulkRequest #3954 This is rare since_bulktends to return 200 even if all items fail but a problem nonetheless.ForEachAsync()should bail out after receiving a faulted task. This was preventing exceptions thrown from halting theBulkAll()in a controlled fashion.Added a callback for every
BulkResponsereceived.OnNext()is for being notified when a batch succeeded but that might constitute multipleBulk()calls.