Normalize exception from cancelling an observable coordinated operation #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pectedElasticsearchClientException or a OperationCancelledException, this normalizes what gets passed to OnError (OperationCancelledException)
codebrain
reviewed
Aug 15, 2019
| @@ -143,6 +143,9 @@ public TResponse Request<TResponse>(HttpMethod method, string path, PostData dat | |||
| } | |||
| catch (Exception killerException) | |||
| { | |||
| if (killerException is OperationCanceledException && cancellationToken.IsCancellationRequested) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coordinated request observables when aborted could bubble out an
UnexpectedElasticsearchClientExceptionor anOperationCancelledException.This normalizes what gets passed to
OnErrornamely (OperationCancelledException)This is a bug was never released and something that the early termination in
ForEachthat #4014 fixed highlighted.