Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 7.x] Fixing BulkAll indefinitely hanging when failing (#5077) #5095

Merged
merged 1 commit into from
Nov 12, 2020
Merged

[Backport 7.x] Fixing BulkAll indefinitely hanging when failing (#5077) #5095

merged 1 commit into from
Nov 12, 2020

Conversation

stevejgordon
Copy link
Contributor

Backport 9b65068 from #5077

@rmadisonhaynie @stevejgordon
Fixing BulkAll indefinitely hanging when failing (#5077)
7a37891 
Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode and ContinueOnDroppedDocuments is true. This was introduced in #4014 when trying to address a similar issue with backOffTries being ignored.

(cherry picked from commit 9b65068)
Mpdreamz
Mpdreamz approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevejgordon stevejgordon merged commit d41bade into 7.x Nov 12, 2020
@stevejgordon stevejgordon deleted the backport-5077-to-7.x branch November 12, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevejgordon @Mpdreamz @rmadisonhaynie