Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: fix golint target #4183

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Makefile: fix golint target #4183

merged 2 commits into from
Sep 10, 2020

Conversation

axw
Copy link
Member

@axw axw commented Sep 9, 2020

Motivation/summary

Fix make golint issue noted in #3725

Checklist

I have considered changes for:
- [ ] documentation
- [ ] logging (add log lines, choose appropriate log selector, etc.)
- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)
- [ ] automated tests (add tests for the code changes, all unit tests pass locally)
- [ ] telemetry
- [ ] Elasticsearch Service (https://cloud.elastic.co)
- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)
- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)

How to test these changes

  1. Add the following to main.go:
// Bar foos
func Foo() {
}
  1. Run make golint
  2. Check output is something like
/home/you/projects/apm-server/main.go:32:1: comment on exported function Foo should be of the form "Foo ..."
make: *** [Makefile:203: golint] Error 1

Related issues

Closes #3725

@apmmachine
Copy link
Contributor

apmmachine commented Sep 9, 2020 •
edited
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4183 updated]

  • Start Time: 2020-09-10T08:54:16.954+0000

  • Duration: 45 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 3540
Skipped 145
Total 3685

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-10T09:09:45.063+0000

    • log

  • Name: Run Linux tests

    • Description: ./script/jenkins/linux-test.sh

    • Duration: 20 min 17 sec

    • Start Time: 2020-09-10T09:04:03.081+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-10T09:24:23.062+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 50 sec

    • Start Time: 2020-09-10T09:04:10.152+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-09-10T09:24:20.117Z] === RUN   TestAPIKeyCreate
[2020-09-10T09:24:20.117Z] --- PASS: TestAPIKeyCreate (2.26s)
[2020-09-10T09:24:20.117Z] === RUN   TestAPIKeyCreateExpiration
[2020-09-10T09:24:20.117Z] --- PASS: TestAPIKeyCreateExpiration (2.02s)
[2020-09-10T09:24:20.117Z] === RUN   TestAPIKeyInvalidateName
[2020-09-10T09:24:20.117Z] --- PASS: TestAPIKeyInvalidateName (3.07s)
[2020-09-10T09:24:20.117Z] === RUN   TestAPIKeyInvalidateID
[2020-09-10T09:24:20.117Z] --- PASS: TestAPIKeyInvalidateID (2.01s)
[2020-09-10T09:24:20.117Z] === RUN   TestAPMServerEnvironment
[2020-09-10T09:24:20.117Z] === RUN   TestAPMServerEnvironment/container
[2020-09-10T09:24:20.117Z] === PAUSE TestAPMServerEnvironment/container
[2020-09-10T09:24:20.117Z] === RUN   TestAPMServerEnvironment/systemd
[2020-09-10T09:24:20.117Z] === PAUSE TestAPMServerEnvironment/systemd
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServerEnvironment/macos_service
[2020-09-10T09:24:20.118Z] === PAUSE TestAPMServerEnvironment/macos_service
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServerEnvironment/windows_service
[2020-09-10T09:24:20.118Z] === PAUSE TestAPMServerEnvironment/windows_service
[2020-09-10T09:24:20.118Z] === CONT  TestAPMServerEnvironment/container
[2020-09-10T09:24:20.118Z] === CONT  TestAPMServerEnvironment/macos_service
[2020-09-10T09:24:20.118Z] === CONT  TestAPMServerEnvironment/windows_service
[2020-09-10T09:24:20.118Z] === CONT  TestAPMServerEnvironment/systemd
[2020-09-10T09:24:20.118Z] --- PASS: TestAPMServerEnvironment (0.00s)
[2020-09-10T09:24:20.118Z]     --- PASS: TestAPMServerEnvironment/windows_service (1.51s)
[2020-09-10T09:24:20.118Z]     --- PASS: TestAPMServerEnvironment/macos_service (1.51s)
[2020-09-10T09:24:20.118Z]     --- PASS: TestAPMServerEnvironment/systemd (1.52s)
[2020-09-10T09:24:20.118Z]     --- PASS: TestAPMServerEnvironment/container (1.63s)
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServerInstrumentation
[2020-09-10T09:24:20.118Z] --- PASS: TestAPMServerInstrumentation (3.22s)
[2020-09-10T09:24:20.118Z] === RUN   TestJaegerGRPC
[2020-09-10T09:24:20.118Z] --- PASS: TestJaegerGRPC (2.78s)
[2020-09-10T09:24:20.118Z] === RUN   TestJaegerGRPCSampling
[2020-09-10T09:24:20.118Z] --- PASS: TestJaegerGRPCSampling (2.55s)
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServerRequestLoggingValid
[2020-09-10T09:24:20.118Z] --- PASS: TestAPMServerRequestLoggingValid (0.40s)
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServerMonitoring
[2020-09-10T09:24:20.118Z] --- PASS: TestAPMServerMonitoring (2.31s)
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServerMonitoringBuiltinUser
[2020-09-10T09:24:20.118Z] --- PASS: TestAPMServerMonitoringBuiltinUser (1.95s)
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServerOnboarding
[2020-09-10T09:24:20.118Z] --- PASS: TestAPMServerOnboarding (3.06s)
[2020-09-10T09:24:20.118Z] === RUN   TestKeepUnsampled
[2020-09-10T09:24:20.118Z] === RUN   TestKeepUnsampled/false
[2020-09-10T09:24:20.118Z] === RUN   TestKeepUnsampled/true
[2020-09-10T09:24:20.118Z] --- PASS: TestKeepUnsampled (5.56s)
[2020-09-10T09:24:20.118Z]     --- PASS: TestKeepUnsampled/false (2.78s)
[2020-09-10T09:24:20.118Z]     --- PASS: TestKeepUnsampled/true (2.78s)
[2020-09-10T09:24:20.118Z] FAIL
[2020-09-10T09:24:20.118Z] FAIL	github.com/elastic/apm-server/systemtest	185.982s
[2020-09-10T09:24:20.118Z] === RUN   TestAPMServer
[2020-09-10T09:24:20.118Z] 2020/09/10 09:21:07 Building apm-server...
[2020-09-10T09:24:20.118Z] go: downloading github.com/elastic/go-hdrhistogram v0.1.0
[2020-09-10T09:24:20.118Z] go: downloading github.com/ua-parser/uap-go v0.0.0-20200325213135-e1c09f13e2fe
[2020-09-10T09:24:20.118Z] go: downloading github.com/aws/aws-sdk-go-v2 v0.9.0
[2020-09-10T09:24:20.118Z] go: downloading code.cloudfoundry.org/go-loggregator v7.4.0+incompatible
[2020-09-10T09:24:20.118Z] go: downloading github.com/cloudfoundry/noaa v2.1.0+incompatible
[2020-09-10T09:24:20.118Z] go: downloading github.com/elastic/elastic-agent-client/v7 v7.0.0-20200709172729-d43b7ad5833a
[2020-09-10T09:24:20.118Z] go: downloading github.com/cloudfoundry-community/go-cfclient v0.0.0-20190808214049-35bcce23fc5f
[2020-09-10T09:24:20.118Z] go: downloading github.com/Masterminds/semver v1.4.2
[2020-09-10T09:24:20.118Z] go: downloading code.cloudfoundry.org/gofileutils v0.0.0-20170111115228-4d0c80011a0f
[2020-09-10T09:24:20.118Z] go: downloading github.com/gorilla/websocket v1.4.1
[2020-09-10T09:24:20.118Z] go: downloading github.com/cloudfoundry/sonde-go v0.0.0-20171206171820-b33733203bb4
[2020-09-10T09:24:20.118Z] go: downloading github.com/mailru/easyjson v0.7.1
[2020-09-10T09:24:20.118Z] go: downloading code.cloudfoundry.org/go-diodes v0.0.0-20190809170250-f77fb823c7ee
[2020-09-10T09:24:20.118Z] go: downloading code.cloudfoundry.org/rfc5424 v0.0.0-20180905210152-236a6d29298a
[2020-09-10T09:24:20.118Z] go: downloading github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af
[2020-09-10T09:24:20.118Z] 2020/09/10 09:23:38 Built /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4183/src/github.com/elastic/apm-server/apm-server
[2020-09-10T09:24:20.118Z] --- PASS: TestAPMServer (153.57s)
[2020-09-10T09:24:20.118Z] === RUN   TestUnstartedAPMServer
[2020-09-10T09:24:20.118Z] --- PASS: TestUnstartedAPMServer (0.00s)
[2020-09-10T09:24:20.118Z] === RUN   TestExpvar
[2020-09-10T09:24:20.118Z] --- PASS: TestExpvar (1.45s)
[2020-09-10T09:24:20.118Z] PASS
[2020-09-10T09:24:20.118Z] ok  	github.com/elastic/apm-server/systemtest/apmservertest	155.032s
[2020-09-10T09:24:20.118Z] ?   	github.com/elastic/apm-server/systemtest/estest	[no test files]
[2020-09-10T09:24:20.118Z] FAIL
[2020-09-10T09:24:20.118Z] + cleanup
[2020-09-10T09:24:20.118Z] + rm -rf /tmp/tmp.gC1cHCUlCr
[2020-09-10T09:24:20.118Z] + .ci/scripts/docker-get-logs.sh
[2020-09-10T09:24:21.446Z] Post stage
[2020-09-10T09:24:21.457Z] Running in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4183/src/github.com/elastic/apm-server
[2020-09-10T09:24:21.482Z] Archiving artifacts
[2020-09-10T09:24:21.929Z] Recording test results
[2020-09-10T09:24:22.691Z] [WARN] tar: pathPrefix parameter is deprecated.
[2020-09-10T09:24:23.028Z] + tar --version
[2020-09-10T09:24:23.358Z] + tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
[2020-09-10T09:24:23.358Z] tar: system-tests: Cannot stat: No such file or directory
[2020-09-10T09:24:23.358Z] tar: Exiting with failure status due to previous errors
[2020-09-10T09:24:23.375Z] [INFO] system-tests-linux-files.tgz was not compressed or archived : script returned exit code 2
[2020-09-10T09:24:23.515Z] Failed in branch System and Environment Tests
[2020-09-10T09:38:54.270Z] [INFO] For detailed information see: https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/master/10370/display/redirect
[2020-09-10T09:38:56.108Z] Copied 50 artifacts from "APM Integration Test MBP Selector » master" build number 10370
[2020-09-10T09:38:57.177Z] Post stage
[2020-09-10T09:38:57.191Z] Recording test results
[2020-09-10T09:38:58.184Z] Running on Jenkins in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4183
[2020-09-10T09:38:58.247Z] [INFO] getVaultSecret: Getting secrets
[2020-09-10T09:38:58.332Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-09-10T09:38:59.060Z] + chmod 755 generate-build-data.sh
[2020-09-10T09:38:59.060Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4183/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4183/runs/3 FAILURE 2681846
[2020-09-10T09:38:59.311Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4183/runs/3/steps/?limit=10000 -o steps-info.json
[2020-09-10T09:38:59.862Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4183/runs/3/tests/?status=FAILED -o tests-errors.json

@axw axw requested a review from a team September 9, 2020 09:29
@axw
Copy link
Member Author

axw commented Sep 10, 2020

Unrelated test failure, opened #4186

@axw axw merged commit 0beebcf into elastic:master Sep 10, 2020
@axw axw deleted the fix-make-golint branch September 10, 2020 09:41
axw added a commit to axw/apm-server that referenced this pull request Sep 10, 2020
@axw
Makefile: fix golint target (elastic#4183)
dd69357
@axw axw mentioned this pull request Sep 10, 2020
Merged
axw added a commit that referenced this pull request Sep 13, 2020
@axw
Makefile: fix golint target (#4183) (#4187)
e52c3c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalvz jalvz jalvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obscured golint errors
3 participants
@axw @apmmachine @jalvz