Makefile: fix golint target (elastic#4183)

axw · Sep 10, 2020 · dd69357 · dd69357
1 parent 44c2f65
commit dd69357
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -196,11 +196,11 @@ build/index-pattern.json: $(PYTHON) apm-server
 GOLINT_TARGETS?=$(shell go list ./...)
 GOLINT_UPSTREAM?=origin/7.x
 REVIEWDOG_FLAGS?=-conf=reviewdog.yml -f=golint -diff="git diff $(GOLINT_UPSTREAM)"
-GOLINT_COMMAND=$(shell $(GOLINT) ${GOLINT_TARGETS} | grep -v "should have comment" | $(REVIEWDOG) $(REVIEWDOG_FLAGS))
+GOLINT_COMMAND=$(GOLINT) ${GOLINT_TARGETS} | grep -v "should have comment" | $(REVIEWDOG) $(REVIEWDOG_FLAGS)
 
 .PHONY: golint
 golint: $(GOLINT) $(REVIEWDOG)
-	@test -z "$(GOLINT_COMMAND)" || (echo "$(GOLINT_COMMAND)" && exit 1)
+	@output=$$($(GOLINT_COMMAND)); test -z "$$output" || (echo $$output && exit 1)
 
 .PHONY: staticcheck
 staticcheck: $(STATICCHECK)