Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtest: retry deleting ILM policy #4186

Merged

Conversation

axw
Copy link
Member

@axw axw commented Sep 10, 2020

Motivation/summary

Fix intermittent CI issues like the following, by retrying ILM policy deletion.

[2020-09-10T09:24:20.117Z] === RUN   TestTransactionAggregationShutdown
[2020-09-10T09:24:20.117Z]     elasticsearch.go:120: [400 Bad Request] {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Cannot delete policy [apm-rollover-30-days]. It is in use by one or more indices: [apm-8.0.0-error-000001]"}],"type":"illegal_argument_exception","reason":"Cannot delete policy [apm-rollover-30-days]. It is in use by one or more indices: [apm-8.0.0-error-000001]"},"status":400}

Checklist

I have considered changes for:
- [ ] documentation
- [ ] logging (add log lines, choose appropriate log selector, etc.)
- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)

How to test these changes

cd systemtest && go test -v

Related issues

https://apm-ci.elastic.co/blue/organizations/jenkins/apm-server%2Fapm-server-mbp/detail/PR-4183/3/pipeline/130

@axw axw requested a review from a team September 10, 2020 09:39
@axw axw mentioned this pull request Sep 10, 2020
1 task
@codecov-commenter
Copy link

Codecov Report

Merging #4186 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4186      +/-   ##
==========================================
- Coverage   80.72%   80.60%   -0.13%     
==========================================
  Files         154      154              
  Lines        7693     7676      -17     
==========================================
- Hits         6210     6187      -23     
- Misses       1483     1489       +6     
Impacted Files Coverage Δ
beater/middleware/log_middleware.go 84.00% <0.00%> (-8.54%) ⬇️
publish/acker.go 83.33% <0.00%> (-8.34%) ⬇️
...ack/apm-server/aggregation/txmetrics/aggregator.go 92.24% <0.00%> (-0.41%) ⬇️

@apmmachine
Copy link
Contributor

apmmachine commented Sep 10, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4186 updated]

  • Start Time: 2020-09-13T05:39:21.212+0000

  • Duration: 48 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 3540
Skipped 145
Total 3685

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-13T05:54:52.076+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-13T06:08:36.595+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 50 sec

    • Start Time: 2020-09-13T05:49:55.002+0000

    • log

@axw axw merged commit 1acb22f into elastic:master Sep 14, 2020
@axw axw deleted the systemtest-cleanup-elasticsearch-retry-delete-ilm branch September 14, 2020 00:41
axw added a commit to axw/apm-server that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants