fix(canvas): fix potential NPE in canvas pattern dirty callback handler #1032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed before, some extension libraries may create their own
Layer
for customization viaPainter#insertLayer
and probably won't inject thepainter
property into the canvas painter likeecharts-gl
andecharts-for-weixin
[1], this results in a potential NPE in the canvas pattern dirty callback handler.So it's better to remove the redundant
__painter
fromLayer
to reuse the existingpainter
property and injectpainter
inPainter#insertLayer
when it doesn't exist.[1] Error threw in
echarts-for-weixin
when loading the pattern