Iox #1142 add service discovery c binding

[FerdinandSpitzschnueffler]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

This PR introduces the service discovery C binding. The examples will follow in another PR.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Partially closes ServiceDiscovery C binding #1142

[codecov]

Codecov Report

Merging #1160 (c9a4d43) into master (1788a02) will increase coverage by 0.34%.
The diff coverage is 96.58%.

@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
+ Coverage   77.78%   78.12%   +0.34%     
==========================================
  Files         352      353       +1     
  Lines       14291    14408     +117     
  Branches     2014     2030      +16     
==========================================
+ Hits        11116    11256     +140     
+ Misses       2494     2460      -34     
- Partials      681      692      +11     

Flag	Coverage Δ
unittests	77.33% <96.58%> (+0.34%)	⬆️
unittests_timing	14.11% <23.93%> (+0.45%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...include/iceoryx_posh/runtime/service_discovery.hpp	100.00% <ø> (+100.00%)	⬆️
iceoryx_binding_c/source/c_wait_set.cpp	88.52% <88.88%> (+0.03%)	⬆️
iceoryx_binding_c/source/c_listener.cpp	85.00% <89.47%> (+0.84%)	⬆️
...ceoryx_binding_c/source/c2cpp_enum_translation.cpp	100.00% <100.00%> (ø)
iceoryx_binding_c/source/c_notification_info.cpp	100.00% <100.00%> (ø)
iceoryx_binding_c/source/c_service_discovery.cpp	100.00% <100.00%> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp	80.00% <0.00%> (-11.43%)	⬇️
...nternal/popo/building_blocks/chunk_distributor.inl	95.93% <0.00%> (+1.62%)	⬆️
iceoryx_posh/source/runtime/service_discovery.cpp	52.83% <0.00%> (+52.83%)	⬆️

[MatthiasKillat]

Partial review

[MatthiasKillat]

Appears fairly small (if it has space for 1024 Servicedescriptions each larger than 300 bytes). I am not sure something is off here. But will likely change (to something smaller) after #1151 because than we store those in dynamic memory.

[FerdinandSpitzschnueffler]

Got the numbers via "CI Debugging". Don't forget that you have to multiply by 8.

[MatthiasKillat]

Ah yes ... it is a uint64_t. Why I do not know (it is 8 byte aligned then, machine word on 64 bit architectures). But I am not sure access is always aligned for the actual type (many architectures can compensate this). Note that placement new requires an aligned pointer, which is not generally true for the ones we pass (&do_not_touch_me).

TLDR: I think this is broken for some types (those with alignment greater than 8) but have not looked at the details (this is nothing particular to this PR). It is broken on machines that cannot enforce alignment on their own and even then the space may be insufficient.

If we do not have alignment > 8 types then it is ok, if we add those types in the future it can subtly break on some architectures.

[MatthiasKillat]

There is some leak problem which the address sanitizer appears to detect.

CI problems