Iox #1150 remove findservice with container from discovery

[MatthiasKillat]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Remove findService with container return value from Discovery #1150

[codecov]

Codecov Report

Merging #1151 (c299e37) into master (e219b1f) will increase coverage by 0.46%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
+ Coverage   77.03%   77.49%   +0.46%     
==========================================
  Files         350      351       +1     
  Lines       13737    14054     +317     
  Branches     1956     1990      +34     
==========================================
+ Hits        10582    10891     +309     
+ Misses       2503     2500       -3     
- Partials      652      663      +11     

Flag	Coverage Δ
unittests	76.68% <0.00%> (+0.38%)	⬆️
unittests_timing	13.34% <0.00%> (+1.46%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...include/iceoryx_posh/runtime/service_discovery.hpp	0.00% <ø> (ø)
iceoryx_posh/source/roudi/service_registry.cpp	88.31% <ø> (-3.55%)	⬇️
iceoryx_posh/source/runtime/service_discovery.cpp	0.00% <0.00%> (ø)
...include/iceoryx_posh/internal/popo/base_client.inl	81.15% <0.00%> (-18.85%)	⬇️
iceoryx_posh/source/popo/client_options.cpp	85.00% <0.00%> (-15.00%)	⬇️
iceoryx_posh/source/popo/rpc_header.cpp	77.27% <0.00%> (-2.32%)	⬇️
iceoryx_binding_c/source/c_notification_info.cpp	100.00% <0.00%> (ø)
iceoryx_binding_c/source/c_client.cpp	98.90% <0.00%> (ø)
... and 8 more

[FerdinandSpitzschnueffler]

@MatthiasKillat Can you please check if we have to remove code examples for the removed findService method from the `iceoryx-v2-0-0.md?

[MatthiasKillat]

@FerdinandSpitzschnueffler

Can you please check if we have to remove code examples for the removed findService method from the `iceoryx-v2-0-0.md?

Yes, I will do so and change it in the upcoming example PR #1117.

[mossmaurice]

Looks good in general, only minor findings.