iox-#27 Run ServiceDiscovery tests for popo::UntypedServer

[mossmaurice]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

• Split up ServiceDisocvery tests into PUB_SUB-only, PUB_SUB && REQ_RES and PUB_SUB || REQ_RES

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Request/Response communication with iceoryx #27 (partly)

[codecov]

Codecov Report

Merging #1134 (4494b5d) into master (10cda9d) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
- Coverage   76.27%   76.06%   -0.21%     
==========================================
  Files         346      348       +2     
  Lines       13600    13623      +23     
  Branches     1938     1940       +2     
==========================================
- Hits        10373    10362      -11     
- Misses       2595     2630      +35     
+ Partials      632      631       -1     

Flag	Coverage Δ
unittests	75.32% <0.00%> (-0.21%)	⬇️
unittests_timing	11.97% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...include/iceoryx_posh/runtime/service_discovery.hpp	0.00% <ø> (ø)
iceoryx_posh/source/runtime/service_discovery.cpp	0.00% <0.00%> (ø)
iceoryx_posh/source/roudi/port_manager.cpp	80.53% <0.00%> (-1.16%)	⬇️
...eoryx_posh/include/iceoryx_posh/popo/publisher.hpp	100.00% <0.00%> (ø)
...posh/include/iceoryx_posh/internal/popo/sample.inl	100.00% <0.00%> (ø)
...include/iceoryx_posh/internal/popo/smart_chunk.inl	100.00% <0.00%> (ø)
...iceoryx_posh/internal/popo/untyped_server_impl.inl	0.00% <0.00%> (ø)
...include/iceoryx_posh/internal/popo/base_server.inl	0.00% <0.00%> (ø)

[elBoberido]

Looks good. I didn't reviewed the tests since you wrote that there will be merge conflicts. I'd rather wait until they are fixed :)