Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake warning: empty command-line option #1311

Closed
3 of 4 tasks
dkroenke opened this issue Apr 1, 2022 · 0 comments · Fixed by #1310, #1326 or #1316
Closed
3 of 4 tasks

CMake warning: empty command-line option #1311

dkroenke opened this issue Apr 1, 2022 · 0 comments · Fixed by #1310, #1326 or #1316
Labels
bug Something isn't working
Milestone

Comments

@dkroenke
Copy link
Member

dkroenke commented Apr 1, 2022

Required information

Operating system:
Ubuntu 20.04 LTS

Compiler version:
CMake 3.23.0 (Released on 29-03-2022)
GCC 9.4.0

Observed result or behaviour:
Taken from #1310 (comment)

When building iceoryx_posh with CMake 3.23, it throws a warning:

Ignoring empty string ("") provided on the command line.

This happens because when CMAKE_TOOLCHAIN_FILE is not
defined, TOOLCHAIN_FILE is also not defined and thus is empty.
Workaround this new behavior by setting a variable that contains
a bunch of things, and may also optionally include the
define for the TOOLCHAIN file, which removes the warning.

This is currently causing a warning in the ROS 2 buildfarm with Windows, like > https://ci.ros2.org/view/nightly/job/nightly_win_rel/2257/cmake/ . Note that I've targeted this to the release_2.0 branch, as that is what > we are using for ROS 2. If you'd prefer me to target to master, I'm happy to do that but then I'll request a backport to the release_2.0 > branch.

Build log:

--- stderr: iceoryx_posh
09:40:11 CMake Warning:
09:40:11   Ignoring empty string ("") provided on the command line.
09:40:11 
09:40:11 
09:40:11 ---
09:40:11 Finished <<< iceoryx_posh [2min 0s]

Expected result or behaviour:
No CMake warning shall be emitted.

Conditions where it occurred / Performed steps:

  1. Download custom CMake version
    wget https://cmake.org/files/v3.23/cmake-3.22.0-linux-x86_64.sh
    
  2. Set custom CMake bin path
    export PATH=/foo/bar/tmp/cmake-3.23.0-linux-x86_64/bin:$PATH
    
  3. Build iceoryx with colcon

Note that this warning does not occur on cmake 3.22 or earlier.

Actions:

  • Merge fix into release_2.0 branch thanks to @clalancette
  • increase version number to 2.0.1 and add changelog entry
  • set git tag v2.0.1 in iceoryx
  • backport changes from release branch to master
@dkroenke dkroenke added the bug Something isn't working label Apr 1, 2022
@dkroenke dkroenke added this to the High prio milestone Apr 1, 2022
@dkroenke dkroenke linked a pull request Apr 1, 2022 that will close this issue
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 1, 2022
Create changelog for v2.0.1

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 1, 2022
Create changelog for v2.0.1

Signed-off-by: Dietrich Krönke <[email protected]>
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 1, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 1, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 1, 2022
elBoberido pushed a commit to ApexAI/iceoryx that referenced this issue Apr 1, 2022
Create changelog for v2.0.1

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit that referenced this issue Apr 1, 2022
dkroenke pushed a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
When building iceoryx_posh with CMake 3.23, it throws a warning:

Ignoring empty string ("") provided on the command line.

This happens because when CMAKE_TOOLCHAIN_FILE is not
defined, TOOLCHAIN_FILE is also not defined and thus is empty.
Workaround this new behavior by setting a variable that contains
a bunch of things, and may also *optionally* include the
define for the TOOLCHAIN file, which removes the warning.

Signed-off-by: Chris Lalancette <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
dkroenke pushed a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
When building iceoryx_posh with CMake 3.23, it throws a warning:

Ignoring empty string ("") provided on the command line.

This happens because when CMAKE_TOOLCHAIN_FILE is not
defined, TOOLCHAIN_FILE is also not defined and thus is empty.
Workaround this new behavior by setting a variable that contains
a bunch of things, and may also *optionally* include the
define for the TOOLCHAIN file, which removes the warning.

Signed-off-by: Chris Lalancette <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
Create changelog for v2.0.1

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 4, 2022
dkroenke pushed a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
When building iceoryx_posh with CMake 3.23, it throws a warning:

Ignoring empty string ("") provided on the command line.

This happens because when CMAKE_TOOLCHAIN_FILE is not
defined, TOOLCHAIN_FILE is also not defined and thus is empty.
Workaround this new behavior by setting a variable that contains
a bunch of things, and may also *optionally* include the
define for the TOOLCHAIN file, which removes the warning.

Signed-off-by: Chris Lalancette <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
Create changelog for v2.0.1

Signed-off-by: Dietrich Krönke <[email protected]>
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 7, 2022
elBoberido pushed a commit to ApexAI/iceoryx that referenced this issue Apr 8, 2022
When building iceoryx_posh with CMake 3.23, it throws a warning:

Ignoring empty string ("") provided on the command line.

This happens because when CMAKE_TOOLCHAIN_FILE is not
defined, TOOLCHAIN_FILE is also not defined and thus is empty.
Workaround this new behavior by setting a variable that contains
a bunch of things, and may also *optionally* include the
define for the TOOLCHAIN file, which removes the warning.

Signed-off-by: Chris Lalancette <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 11, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 11, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 11, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
elfenpiff pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
When building iceoryx_posh with CMake 3.23, it throws a warning:

Ignoring empty string ("") provided on the command line.

This happens because when CMAKE_TOOLCHAIN_FILE is not
defined, TOOLCHAIN_FILE is also not defined and thus is empty.
Workaround this new behavior by setting a variable that contains
a bunch of things, and may also *optionally* include the
define for the TOOLCHAIN file, which removes the warning.

Signed-off-by: Chris Lalancette <[email protected]>
elfenpiff pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
Create changelog for v2.0.1

Signed-off-by: Dietrich Krönke <[email protected]>
elfenpiff pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2022
dkroenke added a commit that referenced this issue Apr 14, 2022
…ngs-master

Iox #1311 fix cmake 3.23.0 warnings master
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
When building iceoryx_posh with CMake 3.23, it throws a warning:

Ignoring empty string ("") provided on the command line.

This happens because when CMAKE_TOOLCHAIN_FILE is not
defined, TOOLCHAIN_FILE is also not defined and thus is empty.
Workaround this new behavior by setting a variable that contains
a bunch of things, and may also *optionally* include the
define for the TOOLCHAIN file, which removes the warning.

Signed-off-by: Chris Lalancette <[email protected]>
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
Create changelog for v2.0.1

Signed-off-by: Dietrich Krönke <[email protected]>
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants
@dkroenke and others