Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #1311 fix cmake 3.23.0 warnings master #1316

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Apr 4, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@dkroenke dkroenke added the bugfix Solves a bug label Apr 4, 2022
@dkroenke dkroenke requested review from elfenpiff and elBoberido April 4, 2022 13:48
@dkroenke dkroenke self-assigned this Apr 4, 2022
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from f36a55b to 4a24aa7 Compare April 4, 2022 13:55
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1316 (e645f22) into master (30b03f9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   79.02%   79.03%           
=======================================
  Files         374      374           
  Lines       14676    14676           
  Branches     2048     2048           
=======================================
+ Hits        11598    11599    +1     
- Misses       2405     2407    +2     
+ Partials      673      670    -3     
Flag Coverage Δ
unittests 78.25% <ø> (-0.01%) ⬇️
unittests_timing 15.49% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 88.57% <0.00%> (-2.86%) ⬇️
iceoryx_posh/source/roudi/port_manager.cpp 84.24% <0.00%> (-1.13%) ⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp 65.53% <0.00%> (+0.85%) ⬆️
iceoryx_posh/source/runtime/posh_runtime_impl.cpp 66.91% <0.00%> (+1.48%) ⬆️

elfenpiff
elfenpiff previously approved these changes Apr 5, 2022
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from 4a24aa7 to 9cc4ab7 Compare April 5, 2022 11:52
@dkroenke dkroenke requested review from elBoberido and elfenpiff April 5, 2022 11:53
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from 9cc4ab7 to 94cb835 Compare April 7, 2022 15:04
@dkroenke dkroenke requested a review from elBoberido April 7, 2022 15:05
cmake/cyclonedds/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/googletest/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/cyclonedds/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/cyclonedds/CMakeLists.txt Outdated Show resolved Hide resolved
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from 94cb835 to 423b450 Compare April 11, 2022 15:04
elfenpiff
elfenpiff previously approved these changes Apr 11, 2022
cmake/cyclonedds/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/googletest/CMakeLists.txt Outdated Show resolved Hide resolved
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch 2 times, most recently from 9bc0915 to 17b95a1 Compare April 12, 2022 06:44
elfenpiff
elfenpiff previously approved these changes Apr 12, 2022
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from 17b95a1 to c4cafd7 Compare April 12, 2022 11:09
@dkroenke dkroenke requested a review from elfenpiff April 12, 2022 11:09
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from c4cafd7 to d5b1561 Compare April 12, 2022 11:17
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from d5b1561 to 44d909a Compare April 12, 2022 11:53
@dkroenke dkroenke requested a review from elBoberido April 12, 2022 11:53
elBoberido
elBoberido previously approved these changes Apr 12, 2022
@dkroenke dkroenke force-pushed the iox-#1311-fix-cmake-3.23.0-warnings-master branch from 44d909a to e645f22 Compare April 12, 2022 12:32
@dkroenke dkroenke requested a review from elBoberido April 12, 2022 12:58
@dkroenke dkroenke merged commit d0876ac into eclipse-iceoryx:master Apr 14, 2022
@dkroenke dkroenke deleted the iox-#1311-fix-cmake-3.23.0-warnings-master branch April 14, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake warning: empty command-line option
3 participants