-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #1323 remove cpptoml patch and fix cmake 3.23 warning for release 1.0 #1326
Iox #1323 remove cpptoml patch and fix cmake 3.23 warning for release 1.0 #1326
Conversation
When building iceoryx_posh with CMake 3.23, it throws a warning: Ignoring empty string ("") provided on the command line. This happens because when CMAKE_TOOLCHAIN_FILE is not defined, TOOLCHAIN_FILE is also not defined and thus is empty. Workaround this new behavior by setting a variable that contains a bunch of things, and may also *optionally* include the define for the TOOLCHAIN file, which removes the warning. Signed-off-by: Chris Lalancette <[email protected]>
iceoryx_posh/include/iceoryx_posh/gateway/toml_gateway_config_parser.hpp
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## release_1.0 #1326 +/- ##
===============================================
+ Coverage 73.96% 73.98% +0.01%
===============================================
Files 319 319
Lines 11425 11425
Branches 1972 1972
===============================================
+ Hits 8451 8453 +2
Misses 2196 2196
+ Partials 778 776 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We add here the bugfix for cpptoml to prevent another CMake warning from #1310 ROS CI build (ROS Galactic, Ubuntu Focal, packages-up-to rmw_cyclonedds_cpp) The question here is if we are allowed to make changes in galactic since it is already released. |
@dkroenke AFAIK changes are allowed as long as they don't break API/ABI: |
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Backport of #1325 and #1310 to release 1.0 branch
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References