Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ServiceDiscovery tests #1065

Closed
FerdinandSpitzschnueffler opened this issue Feb 4, 2022 · 0 comments · Fixed by #1171
Closed

Refactor ServiceDiscovery tests #1065

FerdinandSpitzschnueffler opened this issue Feb 4, 2022 · 0 comments · Fixed by #1171
Assignees
@MatthiasKillat
Labels
good first issue Good for newcomers refactoring Refactor code without adding features test A module/integration/stress/etc test for a component
Milestone
High prio

Comments

@FerdinandSpitzschnueffler
Copy link
Contributor

FerdinandSpitzschnueffler commented Feb 4, 2022 •
edited by mossmaurice
Loading

Brief feature description

Many test and variable names in test_service_discovery.cpp could be renamed to make the tests more understandable. Some of the tests could also be simplified and it should be checked if tests are missing (see also #1088 (comment)) and #1088 (comment).
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler added good first issue Good for newcomers refactoring Refactor code without adding features test A module/integration/stress/etc test for a component labels Feb 4, 2022
Merged
21 tasks
@MatthiasKillat MatthiasKillat mentioned this issue Feb 14, 2022
Merged
21 tasks
@elfenpiff elfenpiff added this to the High prio milestone Feb 14, 2022
@mossmaurice mossmaurice mentioned this issue Feb 21, 2022
Merged
21 tasks
@mossmaurice mossmaurice self-assigned this Feb 21, 2022
@mossmaurice mossmaurice mentioned this issue Feb 21, 2022
Merged
21 tasks
@MatthiasKillat MatthiasKillat mentioned this issue Feb 24, 2022
Merged
21 tasks
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Introduce reference discovery for tests
e0b998e 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Introduce reference discovery for tests
766cf07 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Introduce reference discovery for tests
d64a3fd 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Introduce reference discovery for tests
e5de176 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 25, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add search variations
a59d3bf 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 27, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Vary communication pattern
5c97c9d 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 27, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
01fba41 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 27, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
dadaaba 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 27, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
c8d9433 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 27, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
b871195 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 27, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
c006877 
Signed-off-by: Matthias Killat <[email protected]>
@MatthiasKillat MatthiasKillat mentioned this issue Feb 28, 2022
Merged
21 tasks
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
fe5cc84 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add mixed publisher server search scenarios
f62c139 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add release note
41adace 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Introduce reference discovery for tests
ca34971 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add search variations
f9ca8a6 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Vary communication pattern
41db0f5 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
d5d2089 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add mixed publisher server search scenarios
2861008 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Avoid InterOpWait
594c4ef 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Clean up service discovery integration test
441de30 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Fix waiting mechanism in service discovery t…
a170114 
…ests

Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Simplification and renaming
0ba4865 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Restructure tests to find non-existing service
61b95b1 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 24, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add release note
49e7e5a 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Remove redundant test
a2dfcec 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Remove redundant test
77ab5c7 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Introduce reference discovery for tests
412e972 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add search variations
6360f3f 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Vary communication pattern
f689035 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add findService test scenarios
f705ddd 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add mixed publisher server search scenarios
c61a246 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Avoid InterOpWait
4fec87e 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Clean up service discovery integration test
a5e0d37 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Fix waiting mechanism in service discovery t…
4460b7b 
…ests

Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Simplification and renaming
0bfaf39 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Restructure tests to find non-existing service
fc47487 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Add release note
f81bd6b 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue May 31, 2022
@MatthiasKillat
iox-eclipse-iceoryx#1065 Remove redundant test
342ebaa 
Signed-off-by: Matthias Killat <[email protected]>
MatthiasKillat added a commit that referenced this issue Jun 1, 2022
@MatthiasKillat
Merge pull request #1171 from ApexAI/iox-#1065-refactor-service-disco…
6a11ba3 
…very-tests

Iox #1065 refactor service discovery tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthiasKillat MatthiasKillat

Labels
good first issue Good for newcomers refactoring Refactor code without adding features test A module/integration/stress/etc test for a component
Projects
None yet
Milestone
High prio
Development

Successfully merging a pull request may close this issue.

Iox #1065 refactor service discovery tests ApexAI/iceoryx
4 participants
@mossmaurice @elfenpiff @MatthiasKillat @FerdinandSpitzschnueffler