Remove email waitlist #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Update sparkle-sandbox.sh README to highlight proper usage Replace altool with notarytool in release build script (#623) Update embedded data Bump version to 0.26.4 Update homepage history feed after burning (#620) Firefox data import improvements (#622) Set version to 0.26.3 Microsoft logo for address bar animation (#618) Google spreadsheets login fix (#616)
# By Fernando Bunn (6) and others # Via Chris Brind (3) and others * develop: update files and bump release verison Check the image rule compilation error correctly (#635) Check that the alerting WKWebView is currently selected. (#637) Fix issue when unplugging external monitor (#629) Select tabs when browser is not focused (#632) Revert "Update BSK for iOS app group (#630)" (#634) Use updated BSK branch (#627) Version 0.26.5 Embedded files updated Update BSK for iOS app group (#630) Recently Closed Menu Item (#617) Close dashboard when closing tab with cmd + w (#628) chore(deps): bump Autofill to 4.7.0 (#631) Handle legacy crash logs and use proper architecture in symbolicate.js (#621) Detect when Chrome login fails due to keychain prompt denial (#633) Correctly display unprotected sites on dashboard (#624) Update homefavicon (#625) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
# By Sam Symons (14) and others # Via GitHub (1) and others * develop: (45 commits) Revert "Prevent the app from quitting while the Fire button is active" (#690) Disable link preview. (#691) Fire Button quick wins (#677) Bookmarks phase 2 bug fixes (#686) Set version to 0.28.3. Only clear the selection if the selection needs to change. (#689) Set version to 0.28.2. Update embedded files for 0.28.2. Attempt to stop the new tab button from jumping around the UI (#685) Fix of threading issues related to history causing crashes (#688) Add empty autofill isEnabled checks (to update BSK) (#683) Bump BSK to a version that uses updated GRDB (#647) Fix Save Credentials popover on macOS Ventura (#672) Update BSK to latest version + noop updates (#669) Update selectedTabViewModel only when it actually changes (#681) Update BSK to version 21.0.0 (#680) Always add the Autoconsent script (#666) Optimisation of history entry saving (#675) Use localized compare to sort autofill items (#674) 0.28.1 ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
5 tasks
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 18, 2022
Required: Task/Issue URL: https://app.asana.com/0/0/1202144584700632/f iOS PR: duckduckgo/iOS#1190 macOS PR: duckduckgo/macos-browser#615 What kind of version bump will this require?: Major Description: This PR removes the email waitlist. See the task for more details.
* develop: Update the global accent color. (#695) Version 0.28.4 Embedded files updated
|
Test failures are unrelated and also occur on |
tomasstrba
pushed a commit
that referenced
this pull request
Aug 24, 2022
Task/Issue URL: https://app.asana.com/0/1199230911884351/1202144584700631/f Tech Design URL: CC: Description: This PR removes the email waitlist feature. As far as the macOS app is concerned, this change is pretty simple, since it never included any of the waitlist code. All that's done here is update the email URL.
samsymons
added a commit
that referenced
this pull request
Aug 25, 2022
* develop: Version 0.28.5 Embeded files updated Remove email waitlist (#615) update the menu once the favicons have loaded (#696) Remove email waitlist (#615) Update the global accent color. (#695) Version 0.28.4 Embedded files updated Revert "Prevent the app from quitting while the Fire button is active" (#690) Disable link preview. (#691)
samsymons
added a commit
that referenced
this pull request
Aug 25, 2022
* develop: Version 0.28.5 Embeded files updated Remove email waitlist (#615) update the menu once the favicons have loaded (#696) Remove email waitlist (#615) Update the global accent color. (#695) Version 0.28.4 Embedded files updated Revert "Prevent the app from quitting while the Fire button is active" (#690) Disable link preview. (#691) Fire Button quick wins (#677) Set version to 0.28.3. Only clear the selection if the selection needs to change. (#689) Set version to 0.28.2. Update embedded files for 0.28.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1202144584700631/f
Tech Design URL:
CC:
Description:
This PR removes the email waitlist feature. As far as the macOS app is concerned, this change is pretty simple, since it never included any of the waitlist code. All that's done here is update the email URL.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM