update the menu once the favicons have loaded #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Aug 25, 2022
* develop: Version 0.28.5 Embeded files updated Remove email waitlist (#615) update the menu once the favicons have loaded (#696) Remove email waitlist (#615) Update the global accent color. (#695) Version 0.28.4 Embedded files updated Revert "Prevent the app from quitting while the Fire button is active" (#690) Disable link preview. (#691)
samsymons
added a commit
that referenced
this pull request
Aug 25, 2022
* develop: Version 0.28.5 Embeded files updated Remove email waitlist (#615) update the menu once the favicons have loaded (#696) Remove email waitlist (#615) Update the global accent color. (#695) Version 0.28.4 Embedded files updated Revert "Prevent the app from quitting while the Fire button is active" (#690) Disable link preview. (#691) Fire Button quick wins (#677) Set version to 0.28.3. Only clear the selection if the selection needs to change. (#689) Set version to 0.28.2. Update embedded files for 0.28.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202835408626035/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
FaviconManagerand watch the favicons update in the menu when then the favicons manager loadsTesting checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM