Attempt to stop the new tab button from jumping around the UI #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Aug 15, 2022
* develop: Bookmarks phase 2 bug fixes (#686) Attempt to stop the new tab button from jumping around the UI (#685) Fix of threading issues related to history causing crashes (#688) Add empty autofill isEnabled checks (to update BSK) (#683) Bump BSK to a version that uses updated GRDB (#647) Fix Save Credentials popover on macOS Ventura (#672) Update BSK to latest version + noop updates (#669) Update selectedTabViewModel only when it actually changes (#681) Update BSK to version 21.0.0 (#680) Always add the Autoconsent script (#666) Optimisation of history entry saving (#675)
samsymons
added a commit
that referenced
this pull request
Aug 17, 2022
* develop: Fire Button quick wins (#677) Bookmarks phase 2 bug fixes (#686) Set version to 0.28.3. Only clear the selection if the selection needs to change. (#689) Set version to 0.28.2. Update embedded files for 0.28.2. Attempt to stop the new tab button from jumping around the UI (#685) Fix of threading issues related to history causing crashes (#688) Add empty autofill isEnabled checks (to update BSK) (#683) Bump BSK to a version that uses updated GRDB (#647) Fix Save Credentials popover on macOS Ventura (#672)
samsymons
added a commit
that referenced
this pull request
Aug 18, 2022
# By Sam Symons (14) and others # Via GitHub (1) and others * develop: (45 commits) Revert "Prevent the app from quitting while the Fire button is active" (#690) Disable link preview. (#691) Fire Button quick wins (#677) Bookmarks phase 2 bug fixes (#686) Set version to 0.28.3. Only clear the selection if the selection needs to change. (#689) Set version to 0.28.2. Update embedded files for 0.28.2. Attempt to stop the new tab button from jumping around the UI (#685) Fix of threading issues related to history causing crashes (#688) Add empty autofill isEnabled checks (to update BSK) (#683) Bump BSK to a version that uses updated GRDB (#647) Fix Save Credentials popover on macOS Ventura (#672) Update BSK to latest version + noop updates (#669) Update selectedTabViewModel only when it actually changes (#681) Update BSK to version 21.0.0 (#680) Always add the Autoconsent script (#666) Optimisation of history entry saving (#675) Use localized compare to sort autofill items (#674) 0.28.1 ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202406971111777/f
Tech Design URL:
CC:
Description:
This PR updates the navigation bar to only use one new tab button, as the two button approach had a UI glitch when resizing the window when the tabs were at their maximum width.
Note: I haven't touched this code ever, and am not confident that something isn't broken here. I would appreciate some vigilant QA.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM