Autoconsent: prompt only if an actual cookie popup is found #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muodov
requested review from
sammacbeth and
tomasstrba
and removed request for
sammacbeth and
tomasstrba
|
I'm looking for a way to test this, but Swift is new to me, and I didn't find similar tests to copy-paste. The change is fairly simple, so maybe it's ok like this, but I'm open to suggestions :) @tomasstrba |
|
@muodov, lgtm! 👍 |
samsymons
added a commit
that referenced
this pull request
May 4, 2022
# By Sam Symons (2) and others # Via Sam Symons (2) and GitHub (1) * develop: Autoconsent: prompt only when if an actual cookie popup is found (#565) Fix incorrect action name for selfTest (#561) BSK: Check array items for surrogate methods (#563) BSK: Check array items for surrogate methods (#563) Navigation failure handled in navigation bar buttons and their menus (#540) Version 0.23.1 Ensure that we don’t trip an assertion failure when Fireproofing. (#559) Tweak autoconsent events (#554) Remove Punycode reference after recent bump of BSK (#560) If navigationAction does not target main frame open in new tab (#557) Use macos-12 environment in GitHub Actions workflows (#556) Version 0.23.0 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1202088718678388/f
Tech Design URL:
CC:
Description:
Previously we showed the prompt after detecting a CMP. Now we wait until there's an actual visible popup.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM