-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak autoconsent events #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can see. 🙂 I see that you've requested a review from @sammacbeth so I'm going to re-assign this to him to double-check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll have to run npm run rebuild-autoconsent
and commit the updated bundles for these changes to have an effect.
# By Sam Symons (2) and others # Via Sam Symons (2) and GitHub (1) * develop: Autoconsent: prompt only when if an actual cookie popup is found (#565) Fix incorrect action name for selfTest (#561) BSK: Check array items for surrogate methods (#563) BSK: Check array items for surrogate methods (#563) Navigation failure handled in navigation bar buttons and their menus (#540) Version 0.23.1 Ensure that we don’t trip an assertion failure when Fireproofing. (#559) Tweak autoconsent events (#554) Remove Punycode reference after recent bump of BSK (#560) If navigationAction does not target main frame open in new tab (#557) Use macos-12 environment in GitHub Actions workflows (#556) Version 0.23.0 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Task/Issue URL:
Tech Design URL:
CC:
Description:
This is a tiny fix for the duplicate onCompleted event.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM