Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak autoconsent events #554

Merged
merged 5 commits into from
Apr 29, 2022
Merged

Tweak autoconsent events #554

merged 5 commits into from
Apr 29, 2022

Conversation

muodov
Copy link
Member

@muodov muodov commented Apr 22, 2022

Task/Issue URL:
Tech Design URL:
CC:

Description:
This is a tiny fix for the duplicate onCompleted event.

Steps to test this PR:

  1. Build the browser, open the debug console for the background page
  2. Open any page
  3. Verify that onCompleted is only sent once, and not twice

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@muodov muodov requested a review from jdorweiler April 22, 2022 17:01
@jdorweiler jdorweiler requested review from sammacbeth and jdorweiler and removed request for jdorweiler and sammacbeth April 22, 2022 19:36
@muodov muodov changed the title Max/tweak autoconsent events Tweak autoconsent events Apr 25, 2022
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can see. 🙂 I see that you've requested a review from @sammacbeth so I'm going to re-assign this to him to double-check.

@samsymons samsymons assigned sammacbeth and unassigned samsymons Apr 27, 2022
Copy link
Contributor

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have to run npm run rebuild-autoconsent and commit the updated bundles for these changes to have an effect.

@muodov muodov requested a review from sammacbeth April 29, 2022 07:48
@muodov muodov merged commit 57e59d1 into develop Apr 29, 2022
@muodov muodov deleted the max/tweak-autoconsent-events branch April 29, 2022 12:11
samsymons added a commit that referenced this pull request May 4, 2022
# By Sam Symons (2) and others
# Via Sam Symons (2) and GitHub (1)
* develop:
  Autoconsent: prompt only when if an actual cookie popup is found (#565)
  Fix incorrect action name for selfTest (#561)
  BSK: Check array items for surrogate methods (#563)
  BSK: Check array items for surrogate methods (#563)
  Navigation failure handled in navigation bar buttons and their menus (#540)
  Version 0.23.1
  Ensure that we don’t trip an assertion failure when Fireproofing. (#559)
  Tweak autoconsent events (#554)
  Remove Punycode reference after recent bump of BSK (#560)
  If navigationAction does not target main frame open in new tab (#557)
  Use macos-12 environment in GitHub Actions workflows (#556)
  Version 0.23.0

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants