Navigation failure handled in navigation bar buttons and their menus

[tomasstrba]

Task/Issue URL: https://app.asana.com/0/1177771139624306/1201217438689718/f

Description:
Making back/forward navigation buttons and their menus able to cope with navigation error.

Steps to test this PR:
Test back/forward buttons and their menus in regular usage

1. Visit a few urls
2. Test back and forward buttons
3. Display back or forward button menus
4. Navigate to a website using the menu

Test closing back to the parent tab using the back button

1. Open a website with CMD + SHIFT + click on a link
2. Make sure the back button menu contains current website and parent website
3. Close the tab by clicking on the back button
4. Repeat the test and close the tab by selecting "Close and return to ..." menu item

Test going back after navigation error

1. Visit https://badssl.com/
2. Click on "Expired"
3. Make sure back button menu contains error page as the current item + badssl.com as a previous item
4. Go back to badssl.com: 1) by clicking on back, 2) by selecting the menu item

Testing checklist:

• Test with Release configuration
• Test proper deallocation of tabs
• Make sure committed submodule changes are desired

---

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

[mallexxx]

Great, very long awaited fix, @tomasstrba!
Couple of issues I found though:

1. Search for "a"
2. Search for "b"
3. Go back
4. Paste&go to https://expired.badssl.com/

• When error displayed the Forward button is still enabled and Forward menu shows "✅ Oops, a, b". It shouldn't be shown or at least don‘t diplay the "a" item

Another one:

1. Search for "a"
2. Paste&go to https://expired.badssl.com/
3. Without waiting for error screen to display paste&go to https://expired.badssl.com/ again

• webView.reload() is triggered instead of loadRequest for https://expired.badssl.com/ and SERP for "a" is loaded instead

Also if you don‘t mind could you fix another annoying bug:

1. Open new tab
2. Navigate to https://expired.badssl.com/
3. Progress is not hidden when error appears and keeps going

• this can be fixed by...
  Wrapping ProgressView.swift:182 into DispatchQueue.main.async! Ba-dum-tss 🥁

[mallexxx]

Also something not related: the error description doesn‘t respect the view size

[tomasstrba]

Thanks Alex! 👍 I will address all issues tomorrow.

[tomasstrba]

Alex, please, do you have any idea why the textfield isn't breaking the text into multiple lines when I try to resize the window to smaller? Instead it forces the minimum width.

[tomasstrba]

@mallexxx I wasn't able to resolve issues 2 and 4 in a reasonable time. Since they aren't the scope of this PR, can we move on and land the back/forward button improvement?

[mallexxx]

Sorry, @tomasstrba , didn‘t notice your comment, will review today!

[mallexxx]

Alex, please, do you have any idea why the textfield isn't breaking the text into multiple lines when I try to resize the window to smaller? Instead it forces the minimum width.

These settings (+ align center) work for me (feel free to merge in):

[mallexxx]

Looks better now :)
There's still the "b" search in the forward menu if you go back from the error screen but I suppose we can live with it for now. Would you please set up a follow-up task for making a custom wrapper for the back-forward stack and feel free to merge after resolving the conflict

[tomasstrba]

Alex, wow thanks a lot for the layout settings! 🙏 I merged those, resolved the conflict and re-tested again and scoped next steps in https://app.asana.com/0/1177771139624306/1202210923581858/f