Integrate confirm entitlements endpoint for macOS App Store purchase #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afterxleep
approved these changes
Mar 6, 2024
samsymons
added a commit
that referenced
this pull request
Mar 6, 2024
# By Alexey Martemyanov (10) and others # Via GitHub * main: (39 commits) Add Peoplewhiz data broker (#2310) Integrate confirm entitlements endpoint for macOS App Store purchase (#2325) Make dbSaveBloomFilterError pixel daily and continuous (#2299) Subscription UI updates (#2303) Add email pattern on opt-out pixel (#2307) Use compile-time checked generated asset names (#2177) fix bundle name in breakByRaisingSigInt (#2319) BSK update for iOS autofill support to delete all passwords (#2254) Bump BrowserServicesKit (#2309) Bump version to 1.78.0 (132) Fix crash on popup window display; adjust naming (#2315) Bump version to 1.78.0 (131) Set marketing version to 1.78.0 Update embedded files Fix parsing commit log (#2311) DBP: Set correct duration of submit-success pixel (#2308) Publish subsequent internal releases right after building (#2306) DBP disable pixel changes (#2293) Remove duplicated broker items (#2294) fix tab title not updated (#2302) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200019156869587/1206498134325581/f
Description:
Integrate confirm entitlements endpoint for macOS App Store purchase with additional retries in case of failure.
Steps to test this PR:
Success scenario:
Failure scenario:
SubscriptionPagesUserScript.swiftAppStorePurchaseFlow.completeSubscriptionPurchase(with: purchaseTransactionJWS)intoAppStorePurchaseFlow.completeSubscriptionPurchase(with: "")to make the confirmation fail.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation