Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription UI updates #2303

Merged
merged 19 commits into from
Mar 5, 2024
Merged

Subscription UI updates #2303

merged 19 commits into from
Mar 5, 2024

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Mar 3, 2024

Task/Issue URL: https://app.asana.com/0/1200019156869587/1206362116109071/f

Description:
Update to MacOS screens following design and copy changes.

Steps to test this PR:
Please refer to the linked task for the scope of the changes and Figma designs attached therein.
Scope of the updates is contained in for both authenticated and unauthenticated states:

  • more menu
  • settings
  • address bar styling for DBP, ITR and subscription pages

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against c11224f

@miasma13 miasma13 force-pushed the michal/subs-ui-updates branch from 1ef5f9e to 74652e7 Compare March 4, 2024 22:17
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
@miasma13 miasma13 marked this pull request as ready for review March 5, 2024 07:59
@miasma13 miasma13 requested a review from afterxleep March 5, 2024 07:59
@miasma13 miasma13 removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
Copy link
Contributor

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@miasma13 miasma13 merged commit 774adaa into main Mar 5, 2024
17 checks passed
@miasma13 miasma13 deleted the michal/subs-ui-updates branch March 5, 2024 18:51
samsymons added a commit that referenced this pull request Mar 6, 2024
# By Alexey Martemyanov (10) and others
# Via GitHub
* main: (39 commits)
  Add Peoplewhiz data broker (#2310)
  Integrate confirm entitlements endpoint for macOS App Store purchase (#2325)
  Make dbSaveBloomFilterError pixel daily and continuous (#2299)
  Subscription UI updates (#2303)
  Add email pattern on opt-out pixel (#2307)
  Use compile-time checked generated asset names (#2177)
  fix bundle name in breakByRaisingSigInt (#2319)
  BSK update for iOS autofill support to delete all passwords (#2254)
  Bump BrowserServicesKit (#2309)
  Bump version to 1.78.0 (132)
  Fix crash on popup window display; adjust naming (#2315)
  Bump version to 1.78.0 (131)
  Set marketing version to 1.78.0
  Update embedded files
  Fix parsing commit log (#2311)
  DBP: Set correct duration of submit-success pixel (#2308)
  Publish subsequent internal releases right after building (#2306)
  DBP disable pixel changes (#2293)
  Remove duplicated broker items (#2294)
  fix tab title not updated (#2302)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants