Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dbSaveBloomFilterError pixel daily and continuous #2299

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Mar 1, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205962557569232/f
iOS PR: duckduckgo/iOS#2526

Description

We're making the dbSaveBloomFilterError pixel fire daily and continuously to be able to better understand impact (ie: number of users affected).

Testing:

Pre-test setup:

For reference the pixel is m_mac_debug_dbsb

  1. You'll want to comment out this line.
  2. Run the app once and enable pixels logging from Debug Menu > Logging > Pixel
  3. Stop the app and consider running defaults delete com.duckduckgo.daily.pixel.storage m_mac_debug_dbsb to clear out the relevant daily pixel from storage.
  4. Check out BSK locally, and include it in the project.
  5. You'll want to comment out this line.
  6. Change this line, so that we're doing throw NSError(domain: "test", code: 5) instead of saving the context.

Test: Ensure you see the pixel firing daily and count

  1. Launch Console.app, select your mac and filter by category:Pixel
  2. Run the app
  3. Wait a few seconds, then ensure Console.app shows both these pixels:
m.mac.debug.dbsb.d {
    d = testing;
    e = 5;
}

and

m.mac.debug.dbsb.c {
    d = testing;
    e = 5;
}

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

ayoy and others added 3 commits March 1, 2024 13:55
Task/Issue URL: https://app.asana.com/0/0/1206628689034177/f

Description:
This change updates publish_dmg_release workflow so that it moves release-related tasks to Done column
in macOS App Board, closes them (all but the release task, incident tasks and Current Objectives projects),
run Create DMG Variants pipeline and instructs the release DRI to announce the release to the company.
@diegoreymendez diegoreymendez force-pushed the diego/make-dbsb-daily-and-continuous branch from 5fd3405 to c7dcd09 Compare March 1, 2024 12:55
case .dbSaveExcludedHTTPSDomainsError:
domainEvent = .dbSaveExcludedHTTPSDomainsError
dailyAndCount = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want changing this pixel to be within scope here.

@diegoreymendez diegoreymendez changed the title Diego/make dbsb daily and continuous Make dbSaveBloomFilterError pixel daily and continuous Mar 1, 2024
@diegoreymendez diegoreymendez self-assigned this Mar 1, 2024
@diegoreymendez diegoreymendez marked this pull request as ready for review March 1, 2024 14:49
@diegoreymendez diegoreymendez requested a review from bwaresiak March 1, 2024 16:27
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

diegoreymendez added a commit to duckduckgo/iOS that referenced this pull request Mar 6, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205962557569232/f

macOS PR: duckduckgo/macos-browser#2299

## Description

We're making the `dbSaveBloomFilterError` pixel fire daily and continuously to be able to better understand impact (ie: number of users affected).

Also fixes an issue in the debug menu that was causing the privacy config to be refreshed an ever-increasing number of times.
@diegoreymendez diegoreymendez merged commit cd5a498 into main Mar 6, 2024
17 checks passed
@diegoreymendez diegoreymendez deleted the diego/make-dbsb-daily-and-continuous branch March 6, 2024 10:57
samsymons added a commit that referenced this pull request Mar 6, 2024
# By Alexey Martemyanov (10) and others
# Via GitHub
* main: (39 commits)
  Add Peoplewhiz data broker (#2310)
  Integrate confirm entitlements endpoint for macOS App Store purchase (#2325)
  Make dbSaveBloomFilterError pixel daily and continuous (#2299)
  Subscription UI updates (#2303)
  Add email pattern on opt-out pixel (#2307)
  Use compile-time checked generated asset names (#2177)
  fix bundle name in breakByRaisingSigInt (#2319)
  BSK update for iOS autofill support to delete all passwords (#2254)
  Bump BrowserServicesKit (#2309)
  Bump version to 1.78.0 (132)
  Fix crash on popup window display; adjust naming (#2315)
  Bump version to 1.78.0 (131)
  Set marketing version to 1.78.0
  Update embedded files
  Fix parsing commit log (#2311)
  DBP: Set correct duration of submit-success pixel (#2308)
  Publish subsequent internal releases right after building (#2306)
  DBP disable pixel changes (#2293)
  Remove duplicated broker items (#2294)
  fix tab title not updated (#2302)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants