-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dbSaveBloomFilterError pixel daily and continuous #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/0/1206628689034177/f Description: This change updates publish_dmg_release workflow so that it moves release-related tasks to Done column in macOS App Board, closes them (all but the release task, incident tasks and Current Objectives projects), run Create DMG Variants pipeline and instructs the release DRI to announce the release to the company.
5fd3405
to
c7dcd09
Compare
diegoreymendez
commented
Mar 1, 2024
case .dbSaveExcludedHTTPSDomainsError: | ||
domainEvent = .dbSaveExcludedHTTPSDomainsError | ||
dailyAndCount = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want changing this pixel to be within scope here.
bwaresiak
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Mar 6, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205962557569232/f macOS PR: duckduckgo/macos-browser#2299 ## Description We're making the `dbSaveBloomFilterError` pixel fire daily and continuously to be able to better understand impact (ie: number of users affected). Also fixes an issue in the debug menu that was causing the privacy config to be refreshed an ever-increasing number of times.
samsymons
added a commit
that referenced
this pull request
Mar 6, 2024
# By Alexey Martemyanov (10) and others # Via GitHub * main: (39 commits) Add Peoplewhiz data broker (#2310) Integrate confirm entitlements endpoint for macOS App Store purchase (#2325) Make dbSaveBloomFilterError pixel daily and continuous (#2299) Subscription UI updates (#2303) Add email pattern on opt-out pixel (#2307) Use compile-time checked generated asset names (#2177) fix bundle name in breakByRaisingSigInt (#2319) BSK update for iOS autofill support to delete all passwords (#2254) Bump BrowserServicesKit (#2309) Bump version to 1.78.0 (132) Fix crash on popup window display; adjust naming (#2315) Bump version to 1.78.0 (131) Set marketing version to 1.78.0 Update embedded files Fix parsing commit log (#2311) DBP: Set correct duration of submit-success pixel (#2308) Publish subsequent internal releases right after building (#2306) DBP disable pixel changes (#2293) Remove duplicated broker items (#2294) fix tab title not updated (#2302) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205962557569232/f
iOS PR: duckduckgo/iOS#2526
Description
We're making the
dbSaveBloomFilterError
pixel fire daily and continuously to be able to better understand impact (ie: number of users affected).Testing:
Pre-test setup:
For reference the pixel is
m_mac_debug_dbsb
defaults delete com.duckduckgo.daily.pixel.storage m_mac_debug_dbsb
to clear out the relevant daily pixel from storage.throw NSError(domain: "test", code: 5)
instead of saving the context.Test: Ensure you see the pixel firing daily and count
category:Pixel
and
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation