Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: heartbeat initial version #502

Closed
wants to merge 11 commits into from
Closed

feat: heartbeat initial version #502

wants to merge 11 commits into from

Conversation

sfroment
Copy link
Member

@sfroment sfroment commented Feb 21, 2025

  • feat: add message type ID heartbeat
  • feat: initial heartbeat version

What type of PR is this?

  • Feature

Description

When a peer is alone in an object we want it to try to find other peer subscribed to the same object

Related Issues and PRs

Added/updated tests?

  • Yes

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Feb 21, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link
Member

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Jan Lewandowski <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak removed the request for review from hoangquocvietuet February 25, 2025 06:40
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
* origin:
  chore: release v0.8.5
  feat(ci): add workflow to test docker image can be built (#517)
  chore: release v0.8.4
  chore: add typescript dep to root
  chore: release v0.8.3
  fix: any types
  fix: prod build; deps misused
  chore: release v0.8.2
  fix: docker build
  fix: buf build modules
  chore: release v0.8.1
  chore: fix rebase
  chore: bump version; update repo url
  chore: release v0.8.0
  chore: rm oliver from codeowners
  chore(deps-dev): bump globals from 15.15.0 to 16.0.0 (#501)
Signed-off-by: Sacha Froment <[email protected]>
* origin/main:
  feat: add package keychain (#513)
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
  fix: enable tracing flag (#508)
@d-roak d-roak marked this pull request as draft February 27, 2025 11:33
@sfroment
Copy link
Member Author

sfroment commented Mar 1, 2025

Closing waiting for #524 to be merge before redoing this with this library

@sfroment sfroment closed this Mar 1, 2025
@sfroment sfroment mentioned this pull request Mar 9, 2025
2 tasks
@d-roak d-roak deleted the feat/heartbeat branch March 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - topic discovery/heartbeat like when you are alone in the DRP topic
5 participants