Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples/grid): 🐛 bug where eventListener is added multiple time #507

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

sfroment
Copy link
Member

What type of PR is this?

  • Bug Fix

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: I can't spawn 25 nodes in CI

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Feb 24, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@sfroment sfroment force-pushed the fix/grid-example branch 11 times, most recently from 17c7a52 to 4d94257 Compare February 25, 2025 17:53
chore: better setinterval

Signed-off-by: Sacha Froment <[email protected]>

chore: try to fix cache

Signed-off-by: Sacha Froment <[email protected]>

chore: test bench

Signed-off-by: Sacha Froment <[email protected]>

chore: test bench

Signed-off-by: Sacha Froment <[email protected]>

chore: remove test file

Signed-off-by: Sacha Froment <[email protected]>

change when cache is set

Signed-off-by: Sacha Froment <[email protected]>

change when cache is set

Signed-off-by: Sacha Froment <[email protected]>

fix: cache

Signed-off-by: Sacha Froment <[email protected]>

fix: cache

Signed-off-by: Sacha Froment <[email protected]>

123

Signed-off-by: Sacha Froment <[email protected]>
Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* origin/main:
  fix: enable tracing flag (#508)
  chore: release v0.8.5
  feat(ci): add workflow to test docker image can be built (#517)
  chore: release v0.8.4
  chore: add typescript dep to root
  chore: release v0.8.3
  fix: any types
  fix: prod build; deps misused
  chore: release v0.8.2
  fix: docker build
  fix: buf build modules
  chore: release v0.8.1
  chore: fix rebase
  chore: bump version; update repo url
@sfroment sfroment merged commit ea626c6 into main Feb 26, 2025
14 checks passed
@sfroment sfroment deleted the fix/grid-example branch February 26, 2025 13:32
sfroment added a commit that referenced this pull request Feb 26, 2025
…hain

* origin/main:
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
sfroment added a commit that referenced this pull request Feb 27, 2025
* origin/main:
  feat: add package keychain (#513)
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
  fix: enable tracing flag (#508)
sfroment added a commit that referenced this pull request Feb 28, 2025
* origin/main:
  feat: add package keychain (#513)
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
  fix: enable tracing flag (#508)
  chore: release v0.8.5
  feat(ci): add workflow to test docker image can be built (#517)
  chore: release v0.8.4
  chore: add typescript dep to root
  chore: release v0.8.3
  fix: any types
  fix: prod build; deps misused
  chore: release v0.8.2
  fix: docker build
  fix: buf build modules
  chore: release v0.8.1
  chore: fix rebase
  chore: bump version; update repo url
sfroment added a commit that referenced this pull request Feb 28, 2025
* origin/main:
  feat: add package keychain (#513)
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
  fix: enable tracing flag (#508)
  chore: release v0.8.5
  feat(ci): add workflow to test docker image can be built (#517)
  chore: release v0.8.4
  chore: add typescript dep to root
  chore: release v0.8.3
  fix: any types
  fix: prod build; deps misused
  chore: release v0.8.2
  fix: docker build
  fix: buf build modules
  chore: release v0.8.1
  chore: fix rebase
  chore: bump version; update repo url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants