Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add log level into ConnectObjectOptions #518

Merged
merged 3 commits into from
Feb 26, 2025
Merged

feat: Add log level into ConnectObjectOptions #518

merged 3 commits into from
Feb 26, 2025

Conversation

hoangquocvietuet
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • Yes
  • No, because why: add config
  • I need help with writing tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@hoangquocvietuet hoangquocvietuet force-pushed the feat/log-level-connect-object branch from 6d03271 to 5dc4eec Compare February 26, 2025 02:05
@hoangquocvietuet
Copy link
Contributor Author

➜ ts-drp git:(feat/log-level-connect-object) ✗ pnpm run lint

[email protected] lint /home/lihwy/dev/topology/ts-drp
eslint .

Oops! Something went wrong! :(

ESLint: 9.21.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@eslint/js' imported from /home/lihwy/dev/topology/ts-drp/eslint.config.mjs
Did you mean to import "@eslint/js/src/index.js"?
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:267:9)
at packageResolve (node:internal/modules/esm/resolve:768:81)
at moduleResolve (node:internal/modules/esm/resolve:854:18)
at defaultResolve (node:internal/modules/esm/resolve:984:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:654:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:603:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:586:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:242:38)
at ModuleJob._link (node:internal/modules/esm/module_job:135:49)
 ELIFECYCLE  Command failed with exit code 2.

@sfroment
Merge remote-tracking branch 'origin/main' into feat/log-level-connec…
a10d185 
…t-object

* origin/main:
  fix: enable tracing flag (#508)
@sfroment
fix: lint
61bb2d8 
Signed-off-by: Sacha Froment <[email protected]>
@sfroment sfroment merged commit 4fbdffd into main Feb 26, 2025
14 checks passed
sfroment added a commit that referenced this pull request Feb 26, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into feat/add-package-keyc…
8347708 
…hain

* origin/main:
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
sfroment added a commit that referenced this pull request Feb 27, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into feat/heartbeat
95387a1 
* origin/main:
  feat: add package keychain (#513)
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
  fix: enable tracing flag (#508)
sfroment added a commit that referenced this pull request Feb 28, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into refactor/fix-typing
9460c63 
* origin/main:
  feat: add package keychain (#513)
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
  fix: enable tracing flag (#508)
  chore: release v0.8.5
  feat(ci): add workflow to test docker image can be built (#517)
  chore: release v0.8.4
  chore: add typescript dep to root
  chore: release v0.8.3
  fix: any types
  fix: prod build; deps misused
  chore: release v0.8.2
  fix: docker build
  fix: buf build modules
  chore: release v0.8.1
  chore: fix rebase
  chore: bump version; update repo url
@sfroment sfroment deleted the feat/log-level-connect-object branch February 28, 2025 13:20
sfroment added a commit that referenced this pull request Feb 28, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into refactor/type-drp
789be6e 
* origin/main:
  feat: add package keychain (#513)
  feat: make resolveConflicts function optional (#487)
  feat: Add log level into ConnectObjectOptions (#518)
  fix(examples/grid): 🐛 bug where eventListener is added multiple time (#507)
  fix: enable tracing flag (#508)
  chore: release v0.8.5
  feat(ci): add workflow to test docker image can be built (#517)
  chore: release v0.8.4
  chore: add typescript dep to root
  chore: release v0.8.3
  fix: any types
  fix: prod build; deps misused
  chore: release v0.8.2
  fix: docker build
  fix: buf build modules
  chore: release v0.8.1
  chore: fix rebase
  chore: bump version; update repo url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfroment sfroment sfroment approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@trungnotchung trungnotchung Awaiting requested review from trungnotchung trungnotchung is a code owner

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangquocvietuet @sfroment