Fix generator incrementality

[Youssef1313]

Fixes #8386

Proposed changes

Customer Impact

Regression?

• Yes / No

Risk

Screenshots

Before

After

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

[Youssef1313]

Collecting a bunch of nodes and using only the first node looks suspicious. I just kept the existing behavior, but definitely worth revisiting.

[dreddy-work]

@Youssef1313 , i was about to ask on issue but can you please add description on these changes and why they are being made now in this PR?

[Youssef1313]

@Youssef1313 , i was about to ask on issue but can you please add description on these changes and why they are being made now in this PR?

Currently, the generator pipeline has IncrementalValueProvider<Compilation> which breaks the whole thing. Every typed character in the IDE will execute the whole generator pipeline, which defeats the purpose of being "incremental". This PR makes the pipeline consists of only the things needed for generation.

[RussKie]

@Youssef1313 while you're at it, do you think you could fully-qualify these types as well (to avoid issues similar to #7346):

winforms/src/System.Windows.Forms.Analyzers/src/System/Windows/Forms/ApplicationConfig.FontDescriptor.cs

Lines 32 to 36 in 503bff4

	string fontFamily = string.IsNullOrWhiteSpace(name)
	? "Control.DefaultFont.FontFamily"
	: $"new FontFamily(\"{name}\")";
	return $"new Font({fontFamily}, {Size.ToString(CultureInfo.InvariantCulture)}f, (FontStyle){(int)Style}, (GraphicsUnit){(int)Unit})";

[dreddy-work]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[elachlan]

A couple of the ApplicationConfigurationGeneratorTests are failing.

[dreddy-work]

@Youssef1313 , any specific reason to opt to change order of prams in tests instead of in record constructor?

[Youssef1313]

No. It just happened that when I wrote the record, I matched the order here:

winforms/src/System.Windows.Forms.Analyzers.CSharp/src/System/Windows/Forms/Generators/ProjectFileReader.cs

Lines 31 to 38 in 7fd92af

	ApplicationConfig projectConfig = new()
	{
	EnableVisualStyles = enableVisualStyles,
	DefaultFont = font,
	HighDpiMode = highDpiMode,
	UseCompatibleTextRendering = useCompatibleTextRendering
	};
	return (projectConfig, null);

as I was focusing more on the generator updates rather than tests.