Fix generator incrementality #8388
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,13 +37,12 @@ public void ApplicationConfigurationInitializeBuilder_GenerateInitialize_can_han | |
| string expected = File.ReadAllText($@"System\Windows\Forms\Generators\MockData\{GetType().Name}.{expectedFileName}.cs"); | ||
|
|
||
| string output = ApplicationConfigurationInitializeBuilder.GenerateInitialize(ns, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: PropertyDefaultValue.EnableVisualStyles, | ||
| DefaultFont: null, | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: PropertyDefaultValue.UseCompatibleTextRendering | ||
| )); | ||
|
|
||
| Assert.Equal(expected, output); | ||
| } | ||
|
|
@@ -58,101 +57,93 @@ public static IEnumerable<object[]> GenerateInitializeData() | |
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: false, | ||
| DefaultFont: null, | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: PropertyDefaultValue.UseCompatibleTextRendering | ||
| ), | ||
| "EnableVisualStyles=false" | ||
| }; | ||
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: true, | ||
| DefaultFont: null, | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: PropertyDefaultValue.UseCompatibleTextRendering | ||
| ), | ||
| "EnableVisualStyles=true" | ||
| }; | ||
|
|
||
| // UseCompatibleTextRendering: false, true | ||
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: PropertyDefaultValue.EnableVisualStyles, | ||
| DefaultFont: null, | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: false | ||
| ), | ||
| "UseCompTextRendering=false" | ||
| }; | ||
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: PropertyDefaultValue.EnableVisualStyles, | ||
| DefaultFont: null, | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: true | ||
| ), | ||
| "UseCompTextRendering=true" | ||
| }; | ||
|
|
||
| // DefaultFont: null, FontDescriptor | ||
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: PropertyDefaultValue.EnableVisualStyles, | ||
| DefaultFont: null, | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: false | ||
| ), | ||
| "DefaultFont=null" | ||
| }; | ||
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
|
There was a problem hiding this comment. @Youssef1313 , any specific reason to opt to change order of prams in tests instead of in There was a problem hiding this comment. No. It just happened that when I wrote the record, I matched the order here: as I was focusing more on the generator updates rather than tests. |
||
| EnableVisualStyles: PropertyDefaultValue.EnableVisualStyles, | ||
| DefaultFont: new FontDescriptor(string.Empty, 12, FontStyle.Bold | FontStyle.Italic, GraphicsUnit.Millimeter).ToString(), | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: true | ||
| ), | ||
| "DefaultFont=default" | ||
| }; | ||
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: PropertyDefaultValue.EnableVisualStyles, | ||
| DefaultFont: new FontDescriptor("Tahoma", 12, FontStyle.Regular, GraphicsUnit.Point).ToString(), | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: true | ||
| ), | ||
| "DefaultFont=Tahoma" | ||
| }; | ||
| yield return new object[] | ||
| { | ||
| culture, | ||
| new ApplicationConfig( | ||
| EnableVisualStyles: PropertyDefaultValue.EnableVisualStyles, | ||
| DefaultFont: new FontDescriptor("Microsoft Sans Serif", 8.25f, FontStyle.Regular, GraphicsUnit.Point).ToString(), | ||
| HighDpiMode: PropertyDefaultValue.DpiMode, | ||
| UseCompatibleTextRendering: true | ||
| ), | ||
| "DefaultFont=SansSerif" | ||
| }; | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collecting a bunch of nodes and using only the first node looks suspicious. I just kept the existing behavior, but definitely worth revisiting.