Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationConfigurationGenerator incremantality is broken #8386

Closed
Youssef1313 opened this issue Dec 14, 2022 · 0 comments · Fixed by #8388
Closed

ApplicationConfigurationGenerator incremantality is broken #8386

Youssef1313 opened this issue Dec 14, 2022 · 0 comments · Fixed by #8388

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Dec 14, 2022 •
edited
Loading

winforms/src/System.Windows.Forms.Analyzers.CSharp/src/System/Windows/Forms/Generators/ApplicationConfigurationGenerator.cs

Lines 74 to 81 in bb8b205

var inputs = context.CompilationProvider
.Combine(syntaxProvider.Collect())
.Combine(globalConfig)
.Select((data, cancellationToken)
=> (Compilation: data.Left.Left,
Nodes: data.Left.Right,
ApplicationConfig: data.Right.ApplicationConfig,
ApplicationConfigDiagnostics: data.Right.Diagnostic));

A compilation shouldn't present in the incremental pipeline.
@Youssef1313 Youssef1313 added the untriaged The team needs to look at this issue in the next triage label Dec 14, 2022
@Youssef1313 Youssef1313 mentioned this issue Dec 14, 2022
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Dec 14, 2022
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Jan 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2023
@dreddy-work dreddy-work removed the untriaged The team needs to look at this issue in the next triage label May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix generator incrementality Youssef1313/winforms
2 participants
@Youssef1313 @dreddy-work