[release/5.0-Preview8] Workaround duplicate package icon in packages #39736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Real fix is dotnet/arcade#5818 but that will take a while to make it into the preview8 branches (if at all).
|
Tagging subscribers to this area: @safern, @ViktorHofer |
safern
approved these changes
Jul 21, 2020
ViktorHofer
approved these changes
Jul 21, 2020
joperezr
approved these changes
Jul 21, 2020
|
Hello @ericstj! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ericstj
added a commit
to ericstj/runtime
that referenced
this pull request
Jul 31, 2020
This reverts commit 498c798.
Anipik
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Revert "Workaround duplicate package icon in packages (#39736)" This reverts commit 498c798. * Ensure CoreCLR pkgproj include packaging props (#39906) Since these projects don't directly consume the nupkg they didn't automatically get props when we added it. * Fix issue with Crossgen2 package excluding Icon (#39972) The latest packaging targets rely on ProjectDefaults inclusion of package icon, but this item was being removed by the Crossgen2 project's targets. Also updating the version of packaging tools to see if we have any other failures.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real fix is dotnet/arcade#5818 but that will
take a while to make it into the preview8 branches (if at all).