Remove duplicate package Icon #5818
Conversation
We were double-including the package icon after we started including @(None) items in the package. Remove the redundant item and use the same property as CSProj pack target for specifying the Icon.
Real fix is dotnet/arcade#5818 but that will take a while to make it into the preview8 branches (if at all).
|
Hello @ericstj! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit Real fix is dotnet/arcade#5818 but that will take a while to make it into the preview8 branches (if at all).
|
@ericstj it looks like this breaks the arcade bump in dotnet/llvm-project#58. It's possible that the way we set up the packaging projects there isn't entirely correct though, so I'd appreciate any pointers. |
|
@akoeplinger this repo has the same bug that coreclr did. Check out this change: dotnet/runtime@7ec5302#diff-e98ea49ea8fa5661939a1d9ffb312bba |
|
Thanks, that did indeed fix the issue. |
|
Cool, sorry for the break. Didn't realize folks outside dotnet/runtime were using pkgproj. We should try to get folks off this if possible. It's largely a relic of a 1.0-era way of shipping the product. |
|
yeah we just copied pieces from dotnet/runtime in order to create a nuget package, happy to get rid of them if possible. |
|
Cam someone please open an issue to track the pkgproj removal in repos outside of dotnet/runtime? Thanks |
|
@ViktorHofer open an issue here in arcade? or in runtime? |
|
In arcade probably as the package lives here. |
|
/cc @rbhanda This was the fix |
We were double-including the package icon after we started including
@(None) items in the package.
Remove the redundant item and use the same property as CSProj pack
target for specifying the Icon.
This was regressed here 50da2e6#r40426132