Ensure CoreCLR pkgproj include packaging props #39906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these projects don't directly consume the nupkg they didn't automatically get props when we added it.
|
Would it be worth updating the CoreCLR pkgproj projects to use the nupkg directly? |
|
Not as part of this change. Need to unblock folks. I'm not a huge fan of the way we consume this package in libraries either. We restore a single project that uses packages, then import that project's generated nuget-props and targets files. Right longer term fix is to integrate pkgproj infra with normal SDK targets so that we can leverage them from any project type (CSProj, generic-proj, etc). That'll enable restore and provide the pkgproj content model. |
safern
approved these changes
Jul 24, 2020
ericstj
added a commit
to ericstj/runtime
that referenced
this pull request
Jul 31, 2020
Since these projects don't directly consume the nupkg they didn't automatically get props when we added it.
Anipik
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Revert "Workaround duplicate package icon in packages (#39736)" This reverts commit 498c798. * Ensure CoreCLR pkgproj include packaging props (#39906) Since these projects don't directly consume the nupkg they didn't automatically get props when we added it. * Fix issue with Crossgen2 package excluding Icon (#39972) The latest packaging targets rely on ProjectDefaults inclusion of package icon, but this item was being removed by the Crossgen2 project's targets. Also updating the version of packaging tools to see if we have any other failures.
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
Aug 3, 2020
Same change as dotnet/runtime#39906
dotnet-maestro bot
added a commit
to dotnet/llvm-project
that referenced
this pull request
Aug 3, 2020
[release/9.x] Update dependencies from dotnet/arcade - Updates: - Microsoft.DotNet.Build.Tasks.Packaging: from 5.0.0-beta.20364.3 to 5.0.0-beta.20374.1 - Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20364.3 to 5.0.0-beta.20374.1 - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20364.3 to 5.0.0-beta.20374.1 - Ensure pkgproj include packaging props Same change as dotnet/runtime#39906 - Update Directory.Build.props
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
Since these projects don't directly consume the nupkg they didn't automatically get props when we added it.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these projects don't directly consume the nupkg they didn't
automatically get props when we added it.