Make BuildCheckForwardingLogger filter the events #10186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perf numbers:
It seems like there is a new perf regression since we have implemented the explicit logger forwarder in #10084. But this fix improves the situation a bit. |
AR-May
requested review from
YuliiaKovalova and
JanKrivanek
and removed request for
YuliiaKovalova
JanKrivanek
requested changes
May 31, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckForwardingLogger.cs
Outdated
Show resolved
Hide resolved
f-alizada
reviewed
Jul 17, 2024
f-alizada
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10068
Context
Currently BuildCheckForwardingLogger does not filter out any of the events, which results in extra perf owerhead.
Changes Made
Made BuildCheckForwardingLogger filter out the events that are not used in BuildCheckConnectorLogger.
Testing
Unit tests & manual runs