Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the source of a big perf overhead when using analyzers on big solutions. #10068

Closed
Tracked by #9829
AR-May opened this issue Apr 24, 2024 · 1 comment · Fixed by #10186
Closed
Tracked by #9829

Investigate the source of a big perf overhead when using analyzers on big solutions. #10068

AR-May opened this issue Apr 24, 2024 · 1 comment · Fixed by #10186
Assignees
@AR-May
Labels
Area: BuildCheck

Comments

@AR-May
Copy link
Member

AR-May commented Apr 24, 2024 •
edited
Loading

Investigate (and fix if possible) ~10s difference in performance on OC rebuild using analyzers (from #9988).
@AR-May AR-May self-assigned this Apr 24, 2024
@JanKrivanek JanKrivanek mentioned this issue Apr 29, 2024
Merged
@AR-May AR-May mentioned this issue May 29, 2024
Merged
@JanKrivanek JanKrivanek mentioned this issue Jul 1, 2024
Open
5 tasks
@AR-May
Copy link
Member Author

AR-May commented Jul 2, 2024 •
edited
Loading

I have created a PR that fixes the perf overhead related to loggers. However, there is still significant difference in perf that we need to investigate.

AR-May added a commit that referenced this issue Jul 31, 2024
@AR-May
Make BuildCheckForwardingLogger filter the events (#10186)
b42cf18 
Fixes #10068

Context
Currently BuildCheckForwardingLogger does not filter out any of the events, which results in extra perf owerhead.

Changes Made
Made BuildCheckForwardingLogger filter out the events that are not used in BuildCheckConnectorLogger.

Testing
Unit tests & manual runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AR-May AR-May

Labels
Area: BuildCheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make BuildCheckForwardingLogger filter the events AR-May/msbuild
2 participants
@JanKrivanek @AR-May