fix: Scrollytelling layout #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear why TypeScript doesn't complain when this prop is missing. Further investigation might be needed.
Remove duplicate <main>, use utility classes instead of inline style
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
approved these changes
Jan 29, 2025
|
Thank you @dzole0311 for walking me through the (pre-) release process again |
AliceR
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Jan 29, 2025
**Related Ticket:** #1402 ### Description of Changes Provide a fallback value for top offset of ScrollyMapContainer: When `topOffset` is undefined it causes the css `top` property to be faulty, which makes the `position: sticky` not working. ### Notes & Questions About Changes Do we still need the whole `useSlidingStickyHeaderProps` logic with the USWDS header? ### Validation / Testing You will to validate in the next-veda instance, making sure the map stays sticky on the top when scrolling down. Related PR on next-veda-ui: developmentseed/next-veda-ui#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes while working on #1403.
Mainly to test if the deploy preview will work :)